order of exceptions in array_to_datetime #19621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19621 +/- ##
==========================================
+ Coverage 91.59% 91.6% +<.01%
==========================================
Files 150 150
Lines 48795 48798 +3
==========================================
+ Hits 44696 44699 +3
Misses 4099 4099
Continue to review full report at Codecov.
|
jreback
approved these changes
Feb 10, 2018
| @@ -56,6 +56,8 @@ from tslibs.timestamps cimport (create_timestamp_from_ts, | |||
| _NS_UPPER_BOUND, _NS_LOWER_BOUND) | |||
| from tslibs.timestamps import Timestamp | |||
|
|
|||
| cdef bint PY2 = str == bytes | |||
|
thanks. ideally want to split up these giant functions (e.g. make smaller functions to handle different types, like the strings) so it easier to read. but progress. |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, cleans things up by moving all the seen_datetime and seen_integer variables to the tops of their respective blocks.
Mainly splits the
try:block forstring_to_dtsup into two pieces based on the two lines in that block that could raise and handles errors more specfically.