BUG: Fixed merge on dtype equal categories #19553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19553 +/- ##
==========================================
+ Coverage 91.6% 91.62% +0.01%
==========================================
Files 150 150
Lines 48750 48780 +30
==========================================
+ Hits 44657 44694 +37
+ Misses 4093 4086 -7
Continue to review full report at Codecov.
|
jorisvandenbossche
approved these changes
Feb 6, 2018
jreback
requested changes
Feb 6, 2018
doc/source/whatsnew/v0.23.0.txt
Outdated
| @@ -679,6 +679,9 @@ Categorical | |||
| - Bug in :func:`pandas.api.types.union_categoricals` returning the wrong result | |||
| when all the categoricals had the same categories, but in a different order. | |||
| This affected :func:`pandas.concat` with Categorical data (:issue:`19096`). | |||
| - Bug in :func:`pandas.merge` when joining on a ``Categorical`` column where | |||
| the categories were unordered and had the same values but in a different | |||
There was a problem hiding this comment.
looks fine
maybe should elevate to a subsection to highlite this
|
Found one more case hit by this ( |
jreback
approved these changes
Feb 8, 2018
|
thanks! looks good @TomAugspurger, yeah way you did docs is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19551