-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify argument passing in period_helper #19550
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19550 +/- ##
==========================================
- Coverage 91.62% 91.61% -0.01%
==========================================
Files 150 150
Lines 48780 48780
==========================================
- Hits 44693 44691 -2
- Misses 4087 4089 +2
Continue to review full report at Codecov.
|
After this and #19540 we’ll be ready to rip out date_info and just use pandas_datetimestruct directly. |
rebase |
thanks. ideally we would blow out all of this c-code and cythonize it (I think you are headed this way) |
Orthogonal to #19540, though will need some small rebasing if/when that goes in.
Instead of passing
relation
argument all over the place, pass it once slightly earlier and make it part ofasfreq_info
.