Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify argument passing in period_helper #19550

Merged
merged 7 commits into from
Feb 8, 2018

Conversation

jbrockmendel
Copy link
Member

Orthogonal to #19540, though will need some small rebasing if/when that goes in.

Instead of passing relation argument all over the place, pass it once slightly earlier and make it part of asfreq_info.

@codecov
Copy link

codecov bot commented Feb 6, 2018

Codecov Report

Merging #19550 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19550      +/-   ##
==========================================
- Coverage   91.62%   91.61%   -0.01%     
==========================================
  Files         150      150              
  Lines       48780    48780              
==========================================
- Hits        44693    44691       -2     
- Misses       4087     4089       +2
Flag Coverage Δ
#multiple 89.98% <ø> (-0.01%) ⬇️
#single 41.73% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 83.64% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36f9052...64fc567. Read the comment docs.

@jbrockmendel
Copy link
Member Author

After this and #19540 we’ll be ready to rip out date_info and just use pandas_datetimestruct directly.

@jreback jreback added Period Period data type Clean labels Feb 7, 2018
@jreback
Copy link
Contributor

jreback commented Feb 8, 2018

rebase

@jreback jreback added this to the 0.23.0 milestone Feb 8, 2018
@jreback jreback merged commit 432642e into pandas-dev:master Feb 8, 2018
@jreback
Copy link
Contributor

jreback commented Feb 8, 2018

thanks. ideally we would blow out all of this c-code and cythonize it (I think you are headed this way)

@jbrockmendel jbrockmendel deleted the phelper8 branch February 8, 2018 14:13
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Period Period data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants