Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused calendar options from period_helper #19534

Merged
merged 2 commits into from
Feb 5, 2018

Conversation

jbrockmendel
Copy link
Member

period_helper supports GREGORIAN_CALENDAR and JULIAN_CALENDAR, but only Gregorian is ever used. This removes that argument, which will allow for the following in follow-ups:

  • Remove a bunch of error checking and propogation boilerplate.
  • Get a a bunch of functions from datetime/np_datetime.h instead of re-implementing them in period_helper.
  • Do the same removals to simplify WIP: implement period_helper in cython #19498

@jbrockmendel
Copy link
Member Author

Travis timeout looks unrelated.

@codecov
Copy link

codecov bot commented Feb 5, 2018

Codecov Report

Merging #19534 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19534      +/-   ##
==========================================
- Coverage   91.62%   91.59%   -0.03%     
==========================================
  Files         150      150              
  Lines       48714    48714              
==========================================
- Hits        44633    44619      -14     
- Misses       4081     4095      +14
Flag Coverage Δ
#multiple 89.96% <ø> (-0.03%) ⬇️
#single 41.75% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.22% <0%> (-1.74%) ⬇️
pandas/util/testing.py 83.64% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de39a15...896bcc0. Read the comment docs.

@jreback jreback added Period Period data type Clean labels Feb 5, 2018
@jreback jreback added this to the 0.23.0 milestone Feb 5, 2018
@jreback jreback merged commit 98f3937 into pandas-dev:master Feb 5, 2018
@jreback
Copy link
Contributor

jreback commented Feb 5, 2018

thanks!

@jbrockmendel jbrockmendel deleted the phelper-gregorian branch February 5, 2018 15:23
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Period Period data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants