Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERR: Better error msg when merging on tz-aware and tz-naive columns #19525

Merged
merged 1 commit into from
Feb 3, 2018

Conversation

reidy-p
Copy link
Contributor

@reidy-p reidy-p commented Feb 3, 2018

@codecov
Copy link

codecov bot commented Feb 3, 2018

Codecov Report

Merging #19525 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19525      +/-   ##
==========================================
- Coverage   91.62%   91.62%   -0.01%     
==========================================
  Files         150      150              
  Lines       48680    48681       +1     
==========================================
- Hits        44603    44602       -1     
- Misses       4077     4079       +2
Flag Coverage Δ
#multiple 89.98% <100%> (-0.01%) ⬇️
#single 41.73% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/merge.py 94.22% <100%> (ø) ⬆️
pandas/util/testing.py 83.64% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8620ab...4823afa. Read the comment docs.

@gfyoung gfyoung added Timezones Timezone data dtype Datetime Datetime data dtype Reshaping Concat, Merge/Join, Stack/Unstack, Explode Error Reporting Incorrect or improved errors from pandas labels Feb 3, 2018
@TomAugspurger TomAugspurger merged commit ed3afc4 into pandas-dev:master Feb 3, 2018
@TomAugspurger
Copy link
Contributor

Thanks!

@TomAugspurger TomAugspurger added this to the 0.23.0 milestone Feb 3, 2018
@reidy-p reidy-p deleted the merge_incompat_datetimes branch February 3, 2018 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Error Reporting Incorrect or improved errors from pandas Reshaping Concat, Merge/Join, Stack/Unstack, Explode Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERR: need a better error message when trying to compare incompat types on merge
3 participants