Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spellcheck of enhancingperf.rst #19516

Merged
merged 4 commits into from
Feb 3, 2018
Merged

Spellcheck of enhancingperf.rst #19516

merged 4 commits into from
Feb 3, 2018

Conversation

tommyod
Copy link
Contributor

@tommyod tommyod commented Feb 2, 2018

Spellcheck of the docs, mostly enhancingperf.rst, and a sentence or two on sparse.rst.

  • Added a short introductory paragraph on enhancing performance.
  • Backticks `` around Series, DataFrame.
  • Typeset variants of ``numba``, (n|N)umba, (c|C)ython, etc as Numba and Cython.
  • Minor rephrasing of sentences, spelling, periods, colons etc.

Cheers. Comments very welcome :)

@codecov
Copy link

codecov bot commented Feb 2, 2018

Codecov Report

Merging #19516 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19516      +/-   ##
==========================================
- Coverage   91.69%   91.67%   -0.03%     
==========================================
  Files         148      148              
  Lines       48561    48561              
==========================================
- Hits        44530    44518      -12     
- Misses       4031     4043      +12
Flag Coverage Δ
#multiple 90.03% <ø> (-0.03%) ⬇️
#single 41.72% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.22% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69cd5fb...5ed6c4a. Read the comment docs.

Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@gfyoung gfyoung added the Clean label Feb 3, 2018
@TomAugspurger TomAugspurger merged commit 3f3b4e0 into pandas-dev:master Feb 3, 2018
@TomAugspurger
Copy link
Contributor

Thanks again @tommyod

harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
* Spellchecked enhancingperf, sparse

* Uppercased 'cython' to 'Cython'

* Typeset variants of numba as 'Numba', as on their page

* Updated reference to Numba docs to latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants