-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added E741 to flake8 config #19496
Added E741 to flake8 config #19496
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19496 +/- ##
==========================================
+ Coverage 91.67% 91.7% +0.02%
==========================================
Files 148 148
Lines 48553 48553
==========================================
+ Hits 44513 44525 +12
+ Misses 4040 4028 -12
Continue to review full report at Codecov.
|
no the excepts should be fixed (there is an issue) |
thanks! |
Hey - out of interest how come we ignore this error (E741) I don't see any instances of it in the codebase and thinking we could now enforce it? |
Not sure. I may have copied it from another config (this came from updates
to flake8's rules).
…On Tue, Sep 18, 2018 at 7:43 PM alimcmaster1 ***@***.***> wrote:
Hey - out of interest how come we ignore this error (E741) I don't see any
instances of it in the codebase and thinking we could now enforce it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19496 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIiVVWEoQ0d9m8AUAgg-VgNOtkqReks5ucZMWgaJpZM4R2R8b>
.
|
Makes this easier to run locally.
Do we want to ignore bare exception (E722) too? Or is the hope that we'll fix all those eventually?