Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added E741 to flake8 config #19496

Merged
merged 2 commits into from
Feb 2, 2018
Merged

Conversation

TomAugspurger
Copy link
Contributor

Makes this easier to run locally.

Do we want to ignore bare exception (E722) too? Or is the hope that we'll fix all those eventually?

@codecov
Copy link

codecov bot commented Feb 1, 2018

Codecov Report

Merging #19496 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19496      +/-   ##
==========================================
+ Coverage   91.67%    91.7%   +0.02%     
==========================================
  Files         148      148              
  Lines       48553    48553              
==========================================
+ Hits        44513    44525      +12     
+ Misses       4040     4028      -12
Flag Coverage Δ
#multiple 90.06% <ø> (+0.02%) ⬆️
#single 41.72% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 66.95% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ba063...9abcb98. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Feb 1, 2018

no the excepts should be fixed (there is an issue)
the 1 letter variables are prob ok

@jreback jreback added the Code Style Code style, linting, code_checks label Feb 2, 2018
@jreback jreback added this to the 0.23.0 milestone Feb 2, 2018
@jreback jreback merged commit 6670dfc into pandas-dev:master Feb 2, 2018
@jreback
Copy link
Contributor

jreback commented Feb 2, 2018

thanks!

@TomAugspurger TomAugspurger deleted the flake8-settings branch February 16, 2018 11:54
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
@alimcmaster1
Copy link
Member

Hey - out of interest how come we ignore this error (E741) I don't see any instances of it in the codebase and thinking we could now enforce it?

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Sep 19, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants