Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: GH19404 Changing function signature to match logic #19425

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

upkarlidder
Copy link

@upkarlidder upkarlidder commented Jan 27, 2018

@codecov
Copy link

codecov bot commented Jan 27, 2018

Codecov Report

Merging #19425 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19425   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         150      150           
  Lines       48726    48726           
=======================================
  Hits        44648    44648           
  Misses       4078     4078
Flag Coverage Δ
#multiple 90% <100%> (ø) ⬆️
#single 41.74% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/clipboards.py 100% <ø> (ø) ⬆️
pandas/core/generic.py 95.91% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24d9509...121285f. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Jan 30, 2018

can you also change in pandas.io.clipboards

@jreback jreback added the Output-Formatting __repr__ of pandas objects, to_string label Jan 30, 2018
@upkarlidder
Copy link
Author

@jreback, I thought I already did. There are two changes in this PR. Am I misunderstanding?

pandas.core.generic
pandas.io.clipboards

@jreback jreback added this to the 0.23.0 milestone Feb 1, 2018
@jreback jreback merged commit 09307dd into pandas-dev:master Feb 1, 2018
@jreback
Copy link
Contributor

jreback commented Feb 1, 2018

yep thanks!

harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_clipboard excel defaults to "None", but doc string says "True"
2 participants