updated hist documentation

[mitchnegus]

pandas.DataFrame.hist()/pandas.Series.hist() currently say that the bins keyword argument must be an integer, with a default value of 10. Since these methods are built off matplotlib, these actually seem to be more flexible (allowing sequences as well as integers). I don't know if there was a reason for this discrepancy, but if not, I've adjusted the pandas docstrings to reflect the matplotlib documentation.

Existing pandas documentation
Existing matplotlib documentation

• closes #xxxx
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[pep8speaks]

Hello @mitchnegus! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on January 30, 2018 at 20:49 Hours UTC

[gfyoung]

Could you point to a specific matplotlib function(s) with a "See Also" section in the docstring? As given, if I were a new user, I wouldn't really have an idea of where to go.

[TomAugspurger]

matplotlib.axes.Axes.hist might be turned into a link automatically, if you add it to "See Also".

[TomAugspurger]

Could you also update hist_frame

[TomAugspurger]

matplotlib.axes.Axes.hist might be turned into a link automatically, if you add it to "See Also".

[codecov]

Codecov Report

Merging #19366 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19366   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         150      150           
  Lines       48724    48724           
=======================================
  Hits        44642    44642           
  Misses       4082     4082

Flag	Coverage Δ
#multiple	89.99% <ø> (ø)	⬆️
#single	41.74% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/plotting/_core.py	82.41% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238499a...d0e44e4. Read the comment docs.

[TomAugspurger]

@mitchnegus do you have a chance to update based on these comments?

[mitchnegus]

Yes, sorry, I got busy and had forgot about this. Thanks for the bump!

[TomAugspurger]

Thanks, this all looks good to me. Please ping if you see that all the CI tests have passed before we do.

[jreback]

thanks!