REF: Change how pandas.core.common shim works #19304
Conversation
I have a PR incoming that would introduce a circular dependency between pandas.core.arrays.categorical, pandas.api, and pandas.core.common. This change will allow that PR to avoid hacky workarounds, since the real problem is pandas.core importing pandas.api.types. xref pandas-dev#13990
There was a problem hiding this comment.
Hello..i have a problem in my Facebook when I login it say your account has been disabled
By an administrator I want to know why I am Disabled please and when I can login back I
Hope that you can help me and it thank you for
Any answer you will give it to me bye
|
these are on the list to be removed in 0.23 anyhow( #6581). would rather just take them out. |
|
Hmm, looks like dask uses it in one place :/ Thoughts up bumping it to a FutureWarning for one more release and then removing? |
|
Ah, dask's usage is just compatibility for older pandas (0.19.2, which isn't so long ago). |
|
this should go now |
Codecov Report
@@ Coverage Diff @@
## master #19304 +/- ##
==========================================
- Coverage 91.52% 91.5% -0.03%
==========================================
Files 150 150
Lines 48875 48877 +2
==========================================
- Hits 44733 44723 -10
- Misses 4142 4154 +12
Continue to review full report at Codecov.
|
|
as I said above, just remove the core.common accessors |
|
I think we're undecided on what to do with deprecations slated for 0.23.0, comment from @jorisvandenbossche in #6581 (comment). Let's resolve that in #6581 first. |
|
this was an already slated deprecation for removal |
I have a PR incoming that would introduce a circular dependency
between pandas.core.arrays.categorical, pandas.api, and pandas.core.common.
This change will allow that PR to avoid hacky workarounds, since the
real problem is pandas.core importing pandas.api.types.
xref #13990