Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: change Panel DeprecationWarning -> FutureWarning #19247

Merged
merged 2 commits into from
Jan 16, 2018

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Jan 15, 2018

closes #18324

@jreback jreback added Deprecate Functionality to remove in pandas Panel labels Jan 15, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 15, 2018
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

(was only wondering if we should give it a bit more highlight in the whatsnew docs, not sure to what extent users of it are already well aware of the deprecation or not (which probably depends on what kind of environment they use, eg IPython terminal you see it, but other terminals not)

@jreback
Copy link
Contributor Author

jreback commented Jan 15, 2018

yeah I'll maybe make a sub-section essentially repeating the original whatsnew code.

@codecov
Copy link

codecov bot commented Jan 15, 2018

Codecov Report

Merging #19247 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19247   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         147      147           
  Lines       48827    48827           
=======================================
  Hits        44691    44691           
  Misses       4136     4136
Flag Coverage Δ
#multiple 89.9% <ø> (ø) ⬆️
#single 41.69% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/panel.py 96.83% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9e002...4d1194d. Read the comment docs.

@jreback jreback merged commit c26c49d into pandas-dev:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPR: change Panel DeprecationWarning -> FutureWarning
2 participants