DEPR/CLN: Remove how keyword from df.rolling() etc. #18668
Conversation
topper-123
force-pushed
the
remove_rolling_etc_how
branch
2 times, most recently
from
146918d to
32bf255
Compare
pandas/tests/test_window.py
Outdated
|
|
||
| indices = [datetime(1975, 1, i) for i in range(1, 6)] | ||
| # So that we can have 3 datapoints on last day (4, 10, and 20) | ||
| indices.append(datetime(1975, 1, 5, 1)) |
There was a problem hiding this comment.
just remove the actual how= params, the rest of the tests are ok (you can rename this slightly as well). its possible these tests are somewhat duplicated as well. have a look.
There was a problem hiding this comment.
I think these test look a bit contrieved then ATM, but ok, I will look into them when I refactor pd.stats to see if it makes sense to keep them, possibly in an altered shape.
jreback
added
Deprecate
Codecov Report
@@ Coverage Diff @@
## master #18668 +/- ##
==========================================
- Coverage 91.59% 91.55% -0.05%
==========================================
Files 153 153
Lines 51212 51212
==========================================
- Hits 46908 46887 -21
- Misses 4304 4325 +21
Continue to review full report at Codecov.
|
topper-123
force-pushed
the
remove_rolling_etc_how
branch
from
32bf255 to
2f4ba4e
Compare
|
All green. |
|
thanks @topper-123 |
| - The ``freq`` parameter has been removed from the ``rolling``/``expanding``/``ewm`` methods of DataFrame | ||
| and Series (deprecated since v0.18). Instead, resample before calling the methods. (:issue:18601) | ||
| - The ``freq`` and ``how`` parameters have been removed from the ``rolling``/``expanding``/``ewm`` methods of DataFrame | ||
| and Series (deprecated since v0.18). Instead, resample before calling the methods. (:issue:18601 & :issue:18668) |
There was a problem hiding this comment.
@topper-123 small note for future reference: the issue references need some backticks (see eg line above)
git diff upstream/master -u -- "*.py" | flake8 --diffThe
howparameter of df.rolling/expanding/ewm related methods was deprecated in 0.18 (#11603). This PR removes the parameter from the code base.This PR is a continuation of #18601 (removed the
freqparameter). Next up will be to removepd.stats.*).