-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pandas.read_gbq docs to point to pandas-gbq #18548
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18548 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.02%
==========================================
Files 164 164
Lines 49802 49802
==========================================
- Hits 45496 45487 -9
- Misses 4306 4315 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18548 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.02%
==========================================
Files 164 164
Lines 49802 49802
==========================================
- Hits 45496 45487 -9
- Misses 4306 4315 +9
Continue to review full report at Codecov.
|
Google BigQuery API Client Library v2 for Python is used. | ||
Documentation is available `here | ||
<https://developers.google.com/api-client-library/python/apis/bigquery/v2>`__ | ||
This function requires the `pandas-gbq package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So need to have a section in the pandas-gbq docs on how to deal with < 0.3.0 (IOW list the deps and such).
Also I would remove the referenes here tot the google cloud library itself, you just need to install pandas-gbq, which depending the installed version has different requirements.
also there is a referene in install.rst to pandas-gbq, see if it needs updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, done, and done.
The `pandas-gbq` package must be installed to use `pandas.read_gbq`. Also, with soon-to-be-release version 0.3.0 of `pandas-gbq` the Google Cloud client library is used instead of the Google API library. Also, standard SQL is no longer beta. In fact it is highly recommended over using legacy SQL.
Since this PR no longer talks about explicit dependencies that |
thanks @tswast |
(cherry picked from commit 5cd5e3b)
(cherry picked from commit 5cd5e3b)
The
pandas-gbq
package must be installed to usepandas.read_gbq
.Also, with soon-to-be-release version 0.3.0 of
pandas-gbq
the GoogleCloud client library is used instead of the Google API library.
Also, standard SQL is no longer beta. In fact it is highly recommended
over using legacy SQL.
N/A
- closes #xxxxN/A
(docs change only) - tests added / passedgit diff upstream/master -u -- "*.py" | flake8 --diff
N/A
(docs change only) - whatsnew entry