Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: empty map should not infer #18517

Merged
merged 1 commit into from
Dec 2, 2017
Merged

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Nov 27, 2017

closes #18509

@jreback jreback added API Design Dtype Conversions Unexpected or buggy dtype conversions Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Nov 27, 2017
@jreback jreback added this to the 0.22.0 milestone Nov 27, 2017
@jreback
Copy link
Contributor Author

jreback commented Nov 27, 2017

@codecov
Copy link

codecov bot commented Nov 27, 2017

Codecov Report

Merging #18517 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18517      +/-   ##
==========================================
- Coverage   91.46%   91.45%   -0.02%     
==========================================
  Files         157      157              
  Lines       51447    51439       -8     
==========================================
- Hits        47055    47042      -13     
- Misses       4392     4397       +5
Flag Coverage Δ
#multiple 89.32% <100%> (ø) ⬆️
#single 40.61% <0%> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 82.18% <ø> (+0.28%) ⬆️
pandas/core/indexes/base.py 96.45% <100%> (-0.02%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️
pandas/core/base.py 96.77% <0%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d163de7...2758022. Read the comment docs.

@jreback jreback merged commit e1ba19a into pandas-dev:master Dec 2, 2017
@jorisvandenbossche
Copy link
Member

Sorry for the late reply, but +1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Dtype Conversions Unexpected or buggy dtype conversions Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Series.map({}) should retain the original dtype
2 participants