Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused from datetime.pxd, check for fastpath in ensure_datetime64ns #18453

Merged
merged 2 commits into from
Nov 24, 2017

Conversation

jbrockmendel
Copy link
Member

Still a hodgepodge, but a somewhat smaller hodgepodge.

@jbrockmendel
Copy link
Member Author

Same geopandas error. Looks like its showing up in a couple of PRs (although a couple also have problems I need to fix).

@codecov
Copy link

codecov bot commented Nov 24, 2017

Codecov Report

Merging #18453 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18453      +/-   ##
==========================================
- Coverage   91.35%   91.34%   -0.02%     
==========================================
  Files         163      163              
  Lines       49695    49695              
==========================================
- Hits        45401    45392       -9     
- Misses       4294     4303       +9
Flag Coverage Δ
#multiple 89.14% <ø> (ø) ⬆️
#single 39.66% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6eac0b...6e391d8. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 24, 2017

Codecov Report

Merging #18453 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18453      +/-   ##
==========================================
- Coverage   91.35%   91.31%   -0.05%     
==========================================
  Files         163      163              
  Lines       49695    49695              
==========================================
- Hits        45401    45380      -21     
- Misses       4294     4315      +21
Flag Coverage Δ
#multiple 89.11% <ø> (-0.03%) ⬇️
#single 39.66% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.44% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6eac0b...6e391d8. Read the comment docs.

@jreback jreback added the Clean label Nov 24, 2017
@jreback jreback added this to the 0.22.0 milestone Nov 24, 2017
@jreback jreback merged commit e728f94 into pandas-dev:master Nov 24, 2017
@jreback
Copy link
Contributor

jreback commented Nov 24, 2017

prob should just blow away src/datetime.pxd

@jbrockmendel jbrockmendel deleted the tslibs-todos3 branch November 24, 2017 20:33
@jbrockmendel
Copy link
Member Author

prob should just blow away src/datetime.pxd

Definitely coming up, yah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants