-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: move melt tests to separate file #18428
Conversation
can you rebase this. ping as soon as green to avoid future conflict. |
Codecov Report
@@ Coverage Diff @@
## master #18428 +/- ##
=========================================
Coverage ? 91.31%
=========================================
Files ? 163
Lines ? 49714
Branches ? 0
=========================================
Hits ? 45394
Misses ? 4320
Partials ? 0
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #18428 +/- ##
=========================================
Coverage ? 91.31%
=========================================
Files ? 163
Lines ? 49714
Branches ? 0
=========================================
Hits ? 45394
Misses ? 4320
Partials ? 0
Continue to review full report at Codecov.
|
@jreback when you say 'ping on green' do you mean wait for the three continuous integration services to finish or that big green circle with a checkmark that says 'this branch has no conflicts with the bae branch'? |
the ci to be all green (may take a while) |
@jreback its green now (that took 4 hours?). Looks like there has been another commit to master. Should i rebase again? |
yeah that’s fine- the commit to master fixes the ci issue ci runs for every commit for all prs so quite a queue |
thanks |
This reverts commit e6eac0b.
This breaks out melt, lreshape, and wide_to_long tests into their own module.