Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: move melt tests to separate file #18428

Merged
merged 2 commits into from
Nov 23, 2017
Merged

TST: move melt tests to separate file #18428

merged 2 commits into from
Nov 23, 2017

Conversation

tdpetrou
Copy link
Contributor

This breaks out melt, lreshape, and wide_to_long tests into their own module.

@jreback
Copy link
Contributor

jreback commented Nov 23, 2017

can you rebase this. ping as soon as green to avoid future conflict.

@jreback jreback added Testing pandas testing functions or related to the test suite Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Nov 23, 2017
@jreback jreback added this to the 0.22.0 milestone Nov 23, 2017
@jorisvandenbossche jorisvandenbossche changed the title melt test is in own module TST: move melt tests to separate file Nov 23, 2017
@codecov
Copy link

codecov bot commented Nov 23, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@b45325e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #18428   +/-   ##
=========================================
  Coverage          ?   91.31%           
=========================================
  Files             ?      163           
  Lines             ?    49714           
  Branches          ?        0           
=========================================
  Hits              ?    45394           
  Misses            ?     4320           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.1% <ø> (?)
#single 39.63% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45325e...54226dd. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Nov 23, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@b45325e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #18428   +/-   ##
=========================================
  Coverage          ?   91.31%           
=========================================
  Files             ?      163           
  Lines             ?    49714           
  Branches          ?        0           
=========================================
  Hits              ?    45394           
  Misses            ?     4320           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.1% <ø> (?)
#single 39.63% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45325e...54226dd. Read the comment docs.

@tdpetrou
Copy link
Contributor Author

@jreback when you say 'ping on green' do you mean wait for the three continuous integration services to finish or that big green circle with a checkmark that says 'this branch has no conflicts with the bae branch'?

@jreback
Copy link
Contributor

jreback commented Nov 23, 2017

the ci to be all green (may take a while)

@tdpetrou
Copy link
Contributor Author

@jreback its green now (that took 4 hours?). Looks like there has been another commit to master. Should i rebase again?

@jreback
Copy link
Contributor

jreback commented Nov 23, 2017

yeah that’s fine- the commit to master fixes the ci issue
no need to rebase

ci runs for every commit for all prs so quite a queue

@jreback jreback merged commit e6eac0b into pandas-dev:master Nov 23, 2017
@jreback
Copy link
Contributor

jreback commented Nov 23, 2017

thanks

jorisvandenbossche added a commit that referenced this pull request Nov 24, 2017
@tdpetrou tdpetrou deleted the melt-tests branch November 24, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: split out melt-tests in pandas/tests/reshape/test_reshape.py
2 participants