CLN: remove tseries.util.pivot_annual/isleapyear

[topper-123]

pivot_annual and isleapyear in tseries.util were deprecated in v0.19.

This PR removes them from the code base.

[jreback]

anything worthy of a test for these? eg maybe see if something similar using pivot_table (if not can u construct a test)

[topper-123]

A point is that pivot_table requires dataframes, and pivot_annual works on series [that need to have a DatetimeIndex]. So pivot_table is strictly speaking not doing the same as pivot_annual.

A deeper second issue is that pivot_annual dayofyear number 60 is always febr. 29, while for other pandas date functionality day 60 switches between febr. 29 and 1.mars , depending on whether we're not having a leap year or not.

I'll take a look into if something can be moved. However, do you not think that such date functionality is checked other places, i..e. we duplicate datetime tests by adding them to TestPivotTable? See for example TestPivotTable.test_pivot_timegrouper, line 716 for some date pivot_table tests.

[pep8speaks]

Hello @topper-123! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on November 21, 2017 at 21:05 Hours UTC

[codecov]

Codecov Report

Merging #18370 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18370      +/-   ##
==========================================
- Coverage   91.38%   91.36%   -0.03%     
==========================================
  Files         164      163       -1     
  Lines       49790    49753      -37     
==========================================
- Hits        45501    45455      -46     
- Misses       4289     4298       +9

Flag	Coverage Δ
#multiple	89.16% <ø> (-0.01%)	⬇️
#single	39.57% <ø> (-0.02%)	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	25% <0%> (-58.34%)	⬇️
pandas/core/frame.py	97.8% <0%> (-0.1%)	⬇️
pandas/tseries/offsets.py	96.92% <0%> (+0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b00e62c...38ed067. Read the comment docs.

[codecov]

Codecov Report

Merging #18370 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18370      +/-   ##
==========================================
- Coverage   91.36%   91.34%   -0.03%     
==========================================
  Files         164      163       -1     
  Lines       49733    49690      -43     
==========================================
- Hits        45439    45387      -52     
- Misses       4294     4303       +9

Flag	Coverage Δ
#multiple	89.13% <ø> (-0.01%)	⬇️
#single	39.64% <ø> (-0.05%)	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	25% <0%> (-58.34%)	⬇️
pandas/core/frame.py	97.8% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a2cd3...151c40c. Read the comment docs.

[topper-123]

I've moved test_daily and test_monthly to testPivotTable from TestPivotAnnual. test_hourly could be moved as well, but I'll do that tomorrow.

[jreback]

thanks @topper-123

[jreback]

@topper-123 ok for a followup to move tests if you want.