Separate out arithmetic tests for datetimelike indexes

[jbrockmendel]

As discussed... somewhere. I'll find the reference tomorrow.

This is about as close as I could get to pure cut/paste. There are a few notes to sprinkle in about things to clean up in a follow-up.

In a couple places this wraps some string literals to make folding easier.

[jreback]

can you show the before & after number of tests fo r the affected files (to make sure not missing any). a couple of comments.

[jreback]

so let's move it there

[jreback]

the class names came from a previous round of moving tests, you can remove/rename them if it doesn't make sense (in fact I generally don't like classes for organizing , and much prefer separate well-named files, changing this is out of scope for this PR). This plays nicer with pytest.

[jbrockmendel]

Looking at tests.indexes: 3824 under PR, 3829 under master. Removal of duplicate Julian tests accounts for the difference

[jbrockmendel]

From Travis log:

=================================== FAILURES ===================================
________________ TestClipboard.test_round_trip_valid_encodings _________________
self = <pandas.tests.io.test_clipboard.TestClipboard object at 0x7f8377152438>
    def test_round_trip_valid_encodings(self):
        for enc in ['UTF-8', 'utf-8', 'utf8']:
            for dt in self.data_types:
>               self.check_round_trip_frame(dt, encoding=enc)
pandas/tests/io/test_clipboard.py:136: 
[...]
>       raise AssertionError(msg)
E       AssertionError: DataFrame are different
E       
E       DataFrame shape mismatch
E       [left]:  (5, 3)
E       [right]: (2, 2)
[...]
pandas/util/testing.py:1089: AssertionError
============================ 15513 tests deselected ============================
 1 failed, 518 passed, 22 skipped, 15513 deselected, 1 xfailed in 164.49 seconds 
sys:1: ResourceWarning: unclosed <socket.socket fd=4, family=AddressFamily.AF_INET, type=2050, proto=0, laddr=('0.0.0.0', 0)>
[...]
..ValueError: Buffer dtype mismatch, expected 'Python object' but got 'long'
Exception ignored in: 'pandas._libs.lib.is_bool_array'
ValueError: Buffer dtype mismatch, expected 'Python object' but got 'long'
.................ValueError: Buffer dtype mismatch, expected 'Python object' but got 'long'
Exception ignored in: 'pandas._libs.lib.is_bool_array'
ValueError: Buffer dtype mismatch, expected 'Python object' but got 'long'
.ValueError: Buffer dtype mismatch, expected 'Python object' but got 'long'
Exception ignored in: 'pandas._libs.lib.is_bool_array'
ValueError: Buffer dtype mismatch, expected 'Python object' but got 'long'

No idea if the buffer mismatches are related to the TestClipboard error. The latter has shown up a handful of times and usually goes away with re-running the CI.

[codecov]

Codecov Report

Merging #18049 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18049      +/-   ##
==========================================
- Coverage   91.24%   91.23%   -0.02%     
==========================================
  Files         163      163              
  Lines       50114    50114              
==========================================
- Hits        45729    45720       -9     
- Misses       4385     4394       +9

Flag	Coverage Δ
#multiple	89.04% <ø> (ø)	⬆️
#single	40.24% <ø> (-0.06%)	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	25% <0%> (-58.34%)	⬇️
pandas/core/frame.py	97.75% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65a0f5...f457e43. Read the comment docs.

[codecov]

Codecov Report

Merging #18049 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18049      +/-   ##
==========================================
- Coverage   91.24%   91.23%   -0.02%     
==========================================
  Files         163      163              
  Lines       50114    50114              
==========================================
- Hits        45729    45720       -9     
- Misses       4385     4394       +9

Flag	Coverage Δ
#multiple	89.04% <ø> (ø)	⬆️
#single	40.24% <ø> (-0.06%)	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	25% <0%> (-58.34%)	⬇️
pandas/core/frame.py	97.75% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65a0f5...f457e43. Read the comment docs.

[codecov]

Codecov Report

Merging #18049 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18049      +/-   ##
==========================================
- Coverage   91.24%   91.23%   -0.02%     
==========================================
  Files         163      163              
  Lines       50114    50114              
==========================================
- Hits        45729    45720       -9     
- Misses       4385     4394       +9

Flag	Coverage Δ
#multiple	89.04% <ø> (ø)	⬆️
#single	40.24% <ø> (-0.06%)	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	25% <0%> (-58.34%)	⬇️
pandas/core/frame.py	97.75% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65a0f5...f457e43. Read the comment docs.

[jreback]

the clipboard tests are orthogonal to this. They fail occasionally, a restart of the job usually fixes.

However the is_bool_array is faulting somewhere in cython.

[jreback]

thanks!