Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate tests specific to tslibs modules #18036

Merged
merged 7 commits into from
Oct 31, 2017
Merged

Separate tests specific to tslibs modules #18036

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5822ad9
move tests specific to tslibs.parsing
jbrockmendel Oct 30, 2017
de7d8de
whitespace cleanup
jbrockmendel Oct 30, 2017
a99cd6f
edit per reviewer suggestion
jbrockmendel Oct 30, 2017
7965cab
fixup remove extra assert
jbrockmendel Oct 30, 2017
215bc06
Fix test broken by change to tm.assert_numpy_array_equal
jbrockmendel Oct 30, 2017
a78600a
remove test class duplicated in test_misc
jbrockmendel Oct 30, 2017
beca092
flake8 fixup
jbrockmendel Oct 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/tests/scalar/test_parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,4 +136,4 @@ def test_try_parse_dates(self):

result = parsing.try_parse_dates(arr, dayfirst=True)
expected = [parse(d, dayfirst=True) for d in arr]
assert np.array_equal(result, expected)
assert tm.assert_numpy_array_equal(result, expected)
Copy link
Member

@gfyoung gfyoung Oct 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the assert keyword. tm.assert_... takes care of that for you. As written, this will cause an AssertionError since the function call returns None.