cut/paste AccessorProperty and PandasDelegate to core.accessor #17651
Conversation
|
looks fine; ping when green |
|
Just pushed a fix for the current issue. Keep the implementation of PandasDelegate in core.accessor, but define the final class in core.base to avoid a circular import. |
pandas/core/base.py
Outdated
|
|
||
| def __delete__(self, instance): | ||
| raise AttributeError("can't delete attribute") | ||
| class PandasDelegate(_PandasDelegate, PandasObject): |
There was a problem hiding this comment.
not a fan of this
rather u can simply directly import core.accessor and use it as a mix in class where needed
There was a problem hiding this comment.
Works for me. Coming right up.
Codecov Report
@@ Coverage Diff @@
## master #17651 +/- ##
==========================================
- Coverage 91.26% 91.24% -0.02%
==========================================
Files 163 163
Lines 49776 49780 +4
==========================================
- Hits 45426 45421 -5
- Misses 4350 4359 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17651 +/- ##
==========================================
- Coverage 91.26% 91.24% -0.02%
==========================================
Files 163 163
Lines 49776 49781 +5
==========================================
- Hits 45426 45422 -4
- Misses 4350 4359 +9
Continue to review full report at Codecov.
|
|
thanks! |
To try to get some positive momentum on wrapping up #17042, this PR cut/pastes AccessorProperty and PandasDelegate from core.base to core.accessor, updates the appropriate imports.
The idea is that it will be easier to review actual design changes in isolation of cut/paste changes.
git diff upstream/master -u -- "*.py" | flake8 --diff