Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPAT: cython str-to-int can raise a ValueError on non-CPython #16563

Merged
merged 1 commit into from
May 31, 2017
Merged

COMPAT: cython str-to-int can raise a ValueError on non-CPython #16563

merged 1 commit into from
May 31, 2017

Conversation

mattip
Copy link
Contributor

@mattip mattip commented May 31, 2017

closes #16336

@codecov
Copy link

codecov bot commented May 31, 2017 •
edited
Loading

Codecov Report

Merging #16563 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16563   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         161      161           
  Lines       51074    51074           
=======================================
  Hits        46353    46353           
  Misses       4721     4721
Flag Coverage Δ
#multiple 88.59% <100%> (ø) ⬆️
#single 40.16% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 97.66% <ø> (ø) ⬆️
pandas/core/indexes/base.py 95.74% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d44f3...1cb3a1d. Read the comment docs.

@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label May 31, 2017
@jreback jreback added this to the 0.21.0 milestone May 31, 2017
@jreback jreback merged commit 58f4454 into pandas-dev:master May 31, 2017
@jreback
Copy link
Contributor

jreback commented May 31, 2017

thanks!

Kiv pushed a commit to Kiv/pandas that referenced this pull request Jun 11, 2017
@mattip @Kiv
COMPAT: cython str-to-int can raise a ValueError on non-CPython (pand…
c193235 
…as-dev#16563)
stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
@mattip @stangirala
COMPAT: cython str-to-int can raise a ValueError on non-CPython (pand…
7954a90 
…as-dev#16563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

COMPAT: __Pyx_PyNumber_IntOrLong raises ValueError on PyPy
2 participants
@mattip @jreback