ENH: Make RangeIndex.append() return RangeIndex when possible #16213

toobaz · 2017-05-03T11:42:17Z

closes RangeIndex.append() should return RangeIndex when possible #16212
tests added / passed
passes git diff master --name-only -- '*.py' | flake8 --diff
whatsnew entry

This is analogous to what is already done for RangeIndex.union(), but there doesn't seem to be much scope for code reuse (what could be, in principle, reused in .append of all Index subclasses is the initial casting to list/name handling, I could do in a separate PR).

codecov · 2017-05-03T12:15:59Z

Codecov Report

Merging #16213 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #16213      +/-   ##
==========================================
- Coverage   90.89%   90.87%   -0.02%     
==========================================
  Files         162      162              
  Lines       50884    50915      +31     
==========================================
+ Hits        46250    46269      +19     
- Misses       4634     4646      +12

Flag	Coverage Δ
#multiple	`88.66% <100%> (-0.02%)`	⬇️
#single	`40.32% <58.06%> (+0.01%)`	⬆️

Impacted Files	Coverage Δ
pandas/core/indexes/range.py	`92.81% <100%> (+0.7%)`	⬆️
pandas/plotting/_converter.py	`63.54% <0%> (-1.82%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f154966...a77ee00. Read the comment docs.

codecov · 2017-05-03T12:16:07Z

Codecov Report

Merging #16213 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #16213      +/-   ##
==========================================
- Coverage   90.35%   90.34%   -0.01%     
==========================================
  Files         161      161              
  Lines       50866    50897      +31     
==========================================
+ Hits        45962    45985      +23     
- Misses       4904     4912       +8

Flag	Coverage Δ
#multiple	`88.13% <100%> (ø)`	⬆️
#single	`40.19% <58.06%> (-0.1%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/indexes/range.py	`92.81% <100%> (+0.7%)`	⬆️
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/frame.py	`97.59% <0%> (-0.1%)`	⬇️
pandas/core/common.py	`91.03% <0%> (+0.34%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94ef7b6...89da68a. Read the comment docs.

jreback · 2017-05-03T12:31:16Z

doc/source/whatsnew/v0.20.0.txt

@@ -508,6 +508,7 @@ Other Enhancements
 - Compatability with Jupyter notebook 5.0; MultiIndex column labels are left-aligned and MultiIndex row-labels are top-aligned (:issue:`15379`)

 - ``TimedeltaIndex`` now has a custom datetick formatter specifically designed for nanosecond level precision (:issue:`8711`)
+- ``RangeIndex.append`` now returns a ``RangeIndex`` object when possible (:issue:`16212`)


move to 0.20.1

jreback · 2017-05-03T12:31:47Z

pandas/core/indexes/range.py

+        """
+        Append a collection of Index options together
+
+        Parameters


hmm, yeah any way to share some code?

yes, more or less ready, but it involves many more changes/files and probably some discussion, if it's OK I will open another PR immediately after this

You can simply put up another PR which bases on this one.

I have to fix one error, then I will

jreback · 2017-05-03T23:06:31Z

doc/source/whatsnew/v0.20.1.txt

@@ -18,6 +18,7 @@ Highlights include:

 Enhancements
 ~~~~~~~~~~~~
+- ``RangeIndex.append`` now returns a ``RangeIndex`` object when possible (:issue:`16212`)


move to 0.21.0

toobaz · 2017-05-04T15:58:49Z

The last push just makes few lines of the tests nicer

toobaz · 2017-05-12T06:40:20Z

@jreback as I had anticipated, #16236 involves some non-trivial discussion (and additional work which I won't be able to do in the next days). For the moment, I invite you to reconsider this PR, which should be straightforward: after, it will be easier to focus on that pure refactoring PR.

jorisvandenbossche · 2017-05-12T09:07:35Z

pandas/tests/indexes/test_range.py

@@ -941,3 +941,38 @@ def test_where_array_like(self):
        for klass in klasses:
            result = i.where(klass(cond))
            tm.assert_index_equal(result, expected)
+
+    def test_append(self):


Can you add the issue number as comment?

closes pandas-dev#16212

jreback · 2017-05-12T10:30:02Z

ok, fine to merge. ping on green.

toobaz · 2017-05-12T11:36:56Z

ping

jreback · 2017-05-12T11:45:09Z

thanks!

…-dev#16213) closes pandas-dev#16212

jreback reviewed May 3, 2017

View reviewed changes

jreback added Enhancement Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels May 3, 2017

toobaz force-pushed the range_append branch from a77ee00 to 3a1f6dd Compare May 3, 2017 21:13

jreback reviewed May 3, 2017

View reviewed changes

toobaz force-pushed the range_append branch 2 times, most recently from 4f8762d to 7b3cecb Compare May 4, 2017 14:19

toobaz mentioned this pull request May 4, 2017

CLN: Index.append() refactoring #16236

Merged

2 tasks

jorisvandenbossche approved these changes May 12, 2017

View reviewed changes

ENH: Make RangeIndex.append() return RangeIndex when possible

89da68a

closes pandas-dev#16212

toobaz force-pushed the range_append branch from 7b3cecb to 89da68a Compare May 12, 2017 10:26

jreback added this to the 0.21.0 milestone May 12, 2017

jreback merged commit 50e95e0 into pandas-dev:master May 12, 2017

toobaz deleted the range_append branch May 12, 2017 11:57

pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017

ENH: Make RangeIndex.append() return RangeIndex when possible (pandas…

da0a106

…-dev#16213) closes pandas-dev#16212

stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017

ENH: Make RangeIndex.append() return RangeIndex when possible (pandas…

b03d1f6

…-dev#16213) closes pandas-dev#16212

toobaz mentioned this pull request Aug 22, 2017

REF: Special case NumericIndex._append_same_dtype() #17307

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENH: Make RangeIndex.append() return RangeIndex when possible #16213

ENH: Make RangeIndex.append() return RangeIndex when possible #16213

toobaz commented May 3, 2017

codecov bot commented May 3, 2017

codecov bot commented May 3, 2017 •

edited

Loading

jreback May 3, 2017

jreback May 3, 2017

toobaz May 3, 2017

jreback May 3, 2017

toobaz May 3, 2017 •

edited

Loading

toobaz May 4, 2017

jreback May 3, 2017

toobaz commented May 4, 2017

toobaz commented May 12, 2017

jorisvandenbossche May 12, 2017

toobaz May 12, 2017

jreback commented May 12, 2017

toobaz commented May 12, 2017

jreback commented May 12, 2017

ENH: Make RangeIndex.append() return RangeIndex when possible #16213

ENH: Make RangeIndex.append() return RangeIndex when possible #16213

Conversation

toobaz commented May 3, 2017

codecov bot commented May 3, 2017

Codecov Report

codecov bot commented May 3, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

toobaz May 3, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

toobaz commented May 4, 2017

toobaz commented May 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented May 12, 2017

toobaz commented May 12, 2017

jreback commented May 12, 2017

codecov bot commented May 3, 2017 •

edited

Loading

toobaz May 3, 2017 •

edited

Loading