-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Allow Series with same name with crosstab (#13279) #16028
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bf3c4d1
BUG: Allow series with same in with crosstab (#13279)
mroeschke e825ec9
Add whatsnew
mroeschke c81c478
Accidentally added some files
mroeschke 913baa7
Explain the logic of the fix
mroeschke 4b5302e
Revert 0.20.0 whatsnew
mroeschke 81c8caf
Revert "Revert 0.20.0 whatsnew"
mroeschke fabb2b9
Revert 0.20.0 whatsnew
mroeschke 45daa14
Add related issue number and add period
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -148,8 +148,16 @@ def pivot_table(data, values=None, index=None, columns=None, aggfunc='mean', | |
|
||
table = agged | ||
if table.index.nlevels > 1: | ||
to_unstack = [agged.index.names[i] or i | ||
for i in range(len(index), len(keys))] | ||
# If index_names are integers, determine whether the integers refer | ||
# to the level position or name | ||
index_names = agged.index.names[:len(index)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add a comment here about level names being in integer could be ambiguous (and ref the issue number about this; I think we have one) |
||
to_unstack = [] | ||
for i in range(len(index), len(keys)): | ||
name = agged.index.names[i] | ||
if name is None or name in index_names: | ||
to_unstack.append(i) | ||
else: | ||
to_unstack.append(name) | ||
table = agged.unstack(to_unstack) | ||
|
||
if not dropna: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Add a period at the end of this comment.