Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Refactor Python engine empty line funcs #15946

Merged
merged 1 commit into from
Apr 8, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Apr 7, 2017

The Python engine's _empty and _check_empty methods were uninformative and undocumented.

This commit renames them to _is_line_empty and _remove_empty_lines respectively and provides appropriate documentation.

xref #15925 (comment)

The Python engine's _empty and _check_empty
methods were uninformative and undocumented.

This commit renames them to _is_line_empty
and _remove_empty_lines respectively and
provides appropriate documentation.
@jreback jreback added Clean IO CSV read_csv, to_csv labels Apr 7, 2017
@jreback
Copy link
Contributor

jreback commented Apr 7, 2017

lgtm. ping on green.

@jreback jreback added this to the 0.20.0 milestone Apr 7, 2017
@codecov
Copy link

codecov bot commented Apr 7, 2017

Codecov Report

Merging #15946 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15946   +/-   ##
=======================================
  Coverage   90.98%   90.98%           
=======================================
  Files         145      145           
  Lines       49556    49556           
=======================================
  Hits        45091    45091           
  Misses       4465     4465
Flag Coverage Δ
#multiple 88.75% <100%> (ø) ⬆️
#single 40.57% <28.57%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/parsers.py 95.64% <100%> (ø) ⬆️
pandas/core/internals.py 93.54% <0%> (-0.08%) ⬇️
pandas/util/testing.py 80.88% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d17a94...644d61b. Read the comment docs.

@gfyoung
Copy link
Member Author

gfyoung commented Apr 8, 2017

@jreback : All green and ready to go.

@jreback jreback merged commit 751119f into pandas-dev:master Apr 8, 2017
@jreback
Copy link
Contributor

jreback commented Apr 8, 2017

thanks!

@gfyoung gfyoung deleted the check-empty-clarify branch April 8, 2017 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants