Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove combineAdd and combineMult #15805

Merged
merged 1 commit into from
Mar 26, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Mar 26, 2017

Deprecated in 0.17.0.

xref #10735

@codecov
Copy link

codecov bot commented Mar 26, 2017

Codecov Report

Merging #15805 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15805      +/-   ##
==========================================
- Coverage   91.02%   90.99%   -0.04%     
==========================================
  Files         143      143              
  Lines       49390    49384       -6     
==========================================
- Hits        44957    44936      -21     
- Misses       4433     4448      +15
Impacted Files Coverage Δ
pandas/core/frame.py 97.56% <ø> (-0.41%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f32a0...f86ad56. Read the comment docs.

@jreback jreback added the Deprecate Functionality to remove in pandas label Mar 26, 2017
@jreback jreback added this to the 0.20.0 milestone Mar 26, 2017
@@ -815,6 +815,8 @@ Removal of prior version deprecations/changes
- ``Series``, ``Index``, and ``DataFrame`` have dropped the ``sort`` and ``order`` methods (:issue:`10726`)
- Where clauses in ``pytables`` are only accepted as strings and expressions types and not other data-types (:issue:`12027`)
- The ``LongPanel`` and ``WidePanel`` classes have been removed (:issue:`10892`)
- ``DataFrame`` has dropped the ``combineAdd`` and ``combineMult`` methods in favor of ``add`` and ``mul`` respectively (:issue:`10735`)
- ``Series``, ``Index``, and ``DataFrame`` have dropped the ``convert_objects`` method (:issue:`11173`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this line :<

Copy link
Member Author

@gfyoung gfyoung Mar 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, done.

@gfyoung gfyoung force-pushed the combine-op-removal branch from dc9dca8 to 5c40359 Compare March 26, 2017 03:36
@gfyoung gfyoung force-pushed the combine-op-removal branch from 5c40359 to f86ad56 Compare March 26, 2017 03:38
@jreback jreback merged commit 18ac0b7 into pandas-dev:master Mar 26, 2017
@jreback
Copy link
Contributor

jreback commented Mar 26, 2017

thanks!

@gfyoung gfyoung deleted the combine-op-removal branch March 26, 2017 20:02
mattip pushed a commit to mattip/pandas that referenced this pull request Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants