DOC: Patch new flake8 command grep #15749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The grep was initially matching to "pandas," which is incorrect because that was also matching files containing "pandas" in the name but that were not in the main pandas directory (e.g. performance test code) Follow-up to pandas-devgh-15712 [ci skip]
jreback
reviewed
Mar 20, 2017
| @@ -527,7 +527,7 @@ unused function. However, style-checking the diff will not catch this because | |||
| the actual import is not part of the diff. Thus, for completeness, you should | |||
| run this command, though it will take longer:: | |||
|
|
|||
| git diff master --name-only -- '*.py' | grep 'pandas' | xargs -r flake8 | |||
| git diff master --name-only -- '*.py' | grep 'pandas/' | xargs -r flake8 | |||
There was a problem hiding this comment.
not sure if its worth noting but need to remove the -r on osx :<
otherwise this command looks good to me (I use it!)
There was a problem hiding this comment.
Awesome! But how do you tell xargs to abort the command if the list is empty on OSX? That's the whole reason why I have the -r flag there.
There was a problem hiding this comment.
it just works
(pandas) bash-3.2$ git diff master --name-only -- '*.py' | grep 'pandas/' | xargs -r flake8
xargs: illegal option -- r
usage: xargs [-0opt] [-E eofstr] [-I replstr [-R replacements]] [-J replstr]
[-L number] [-n number [-x]] [-P maxprocs] [-s size]
[utility [argument ...]]
(pandas) bash-3.2$ git diff master --name-only -- '*.py' | grep 'pandas/' | xargs flake8
There was a problem hiding this comment.
Oh, interesting. I did not realize it just aborts like that. Okay, then I'll mention that in the docs.
There was a problem hiding this comment.
@jreback : Made doc patch regarding OSX compatibility with xargs
There was a problem hiding this comment.
On Linux, it means "abort immediately if list is empty." Without that flag, I end up style-checking all Python files in the pandas repository.
OSX xargs has no -r, but it still terminates when xargs is empty, which was the whole point of passing in that flag in the first place. [ci skip]
gfyoung
force-pushed
the
flake8-diff-patch
branch
from
0ea390d to
d1543b5
Compare
|
thanks! |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
The grep was initially matching to "pandas," which is incorrect because that was also matching files containing "pandas" in the name but that were not in the main `pandas` directory (e.g. performance test code). This change enforces that we match to any Python files in the main `pandas` directory. Also picked up compatibility issue with OSX, in which the `-r` flag does not exist. However, `xargs` terminates if the argument list is empty, which was the whole point of passing in `-r` in the first place. Follow-up to pandas-dev#15712 Author: gfyoung <[email protected]> Closes pandas-dev#15749 from gfyoung/flake8-diff-patch and squashes the following commits: d1543b5 [gfyoung] COMPAT: Do not run xargs with -r on OSX da57857 [gfyoung] DOC: Patch new flake8 command grep
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Mar 21, 2017
jreback
pushed a commit
that referenced
this pull request
Mar 21, 2017
mattip
pushed a commit
to mattip/pandas
that referenced
this pull request
Apr 3, 2017
The grep was initially matching to "pandas," which is incorrect because that was also matching files containing "pandas" in the name but that were not in the main `pandas` directory (e.g. performance test code). This change enforces that we match to any Python files in the main `pandas` directory. Also picked up compatibility issue with OSX, in which the `-r` flag does not exist. However, `xargs` terminates if the argument list is empty, which was the whole point of passing in `-r` in the first place. Follow-up to pandas-dev#15712 Author: gfyoung <[email protected]> Closes pandas-dev#15749 from gfyoung/flake8-diff-patch and squashes the following commits: d1543b5 [gfyoung] COMPAT: Do not run xargs with -r on OSX da57857 [gfyoung] DOC: Patch new flake8 command grep
mattip
pushed a commit
to mattip/pandas
that referenced
this pull request
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grep was initially matching to "pandas," which is incorrect because that was also matching files containing "pandas" in the name but that were not in the main
pandasdirectory (e.g. performance test code). This change enforces that we match to any Python files in the mainpandasdirectory.Also picked up compatibility issue with OSX, in which the
-rflag does not exist. However,xargsterminates if the argument list is empty, which was the whole point of passing in-rin the first place.Follow-up to #15712