Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Test pivot with categorical data #14807

Closed

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Dec 6, 2016

closes #8860
closes #8731
closes #9534

Looks like the examples in these issues pass in the master branch. Added test to confirm.

@jreback jreback added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite Categorical Categorical Data Type labels Dec 6, 2016
@jreback jreback added this to the 0.19.2 milestone Dec 6, 2016
@jreback
Copy link
Contributor

jreback commented Dec 6, 2016

@mroeschke thanks!

can you see if you can figure out what issues solved these and list here.

If they are in 0.19.2 or 0.20, then we want to add these issues to the current whatsnew.

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Dec 6, 2016

Cool!
It seems they were already solved in 0.19.0

@codecov-io
Copy link

Current coverage is 85.28% (diff: 100%)

Merging #14807 into master will increase coverage by <.01%

@@             master     #14807   diff @@
==========================================
  Files           144        144          
  Lines         50953      50968    +15   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43452      43467    +15   
  Misses         7501       7501          
  Partials          0          0          

Powered by Codecov. Last update 4378f82...b506083

@mroeschke
Copy link
Member Author

Looks like #11371 may have helped address these issues back in 0.17.1, but I am not finding any recent PRs fixing these issues.

@jreback
Copy link
Contributor

jreback commented Dec 6, 2016

thanks!

@jreback jreback closed this in 1725d24 Dec 6, 2016
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, 0.19.2 Dec 6, 2016
@mroeschke mroeschke deleted the test_pivot_categoricals branch December 20, 2017 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite
Projects
None yet
4 participants