BUG: DatetimeTZBlock can't assign values near dst boundary #14146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Bug
Dtype Conversions
| @@ -1038,7 +1038,7 @@ def test_fillna_series_datetime64tz(self): | |||
| # datetime64tz + int => datetime64tz | |||
| # ToDo: must be object | |||
| exp = pd.Series([pd.Timestamp('2011-01-01', tz=tz), | |||
| pd.Timestamp(1).tz_localize(tz=tz), | |||
| pd.Timestamp(1, tz=tz), | |||
There was a problem hiding this comment.
Both cases are incorrect. Being fixed by #14145.
Current coverage is 85.24% (diff: 100%)@@ master #14146 diff @@
==========================================
Files 140 140
Lines 50556 50556
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43095 43095
Misses 7461 7461
Partials 0 0
|
| @@ -2314,7 +2317,10 @@ def __init__(self, values, placement, ndim=2, **kwargs): | |||
| if dtype is not None: | |||
| if isinstance(dtype, compat.string_types): | |||
| dtype = DatetimeTZDtype.construct_from_string(dtype) | |||
| values = values.tz_localize('UTC').tz_convert(dtype.tz) | |||
|
|
|||
| if isinstance(values, DatetimeTZBlock): | |||
There was a problem hiding this comment.
Looks never, it was needed for initial trial. Removed.
|
@sinhrks just that question from above. |
sinhrks
force-pushed
the
internals_datetimetz
branch
from
ae76d87 to
95aa6b5
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffValue assignment doesn't work if data contains DST boundary because of internal
.localize(None).