BUG: disallow 'w' mode in pd.read_hdf (#13623) #13858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -303,6 +303,8 @@ def read_hdf(path_or_buf, key=None, **kwargs): | |||
|
|
|||
| """ | |||
|
|
|||
| if 'mode' in kwargs and kwargs['mode'] == 'w': | |||
|
needs tests |
Current coverage is 85.25% (diff: 100%)@@ master #13858 diff @@
==========================================
Files 140 140
Lines 50455 50457 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43014 43017 +3
+ Misses 7441 7440 -1
Partials 0 0
|
iamsimha
force-pushed
the
fixing_issue_13623
branch
2 times, most recently
from
a324cb7 to
785f386
Compare
|
The existing test cases check for r, r+, a and w modes. I have added a new test case to check read_hdf for default mode (i.e without mode argument given). |
| @@ -303,6 +303,9 @@ def read_hdf(path_or_buf, key=None, **kwargs): | |||
|
|
|||
| """ | |||
|
|
|||
| if kwargs.get('mode') == 'w': | |||
There was a problem hiding this comment.
Should raise other invalid mode here?
There was a problem hiding this comment.
Fixed. Now instead of checking for invalid modes, I check only for valid modes and raise a ValueError if any invalid modes are passed.
sinhrks
added
Error Reporting
iamsimha
force-pushed
the
fixing_issue_13623
branch
from
785f386 to
8359d0b
Compare
| @@ -303,6 +303,9 @@ def read_hdf(path_or_buf, key=None, **kwargs): | |||
|
|
|||
| """ | |||
|
|
|||
| if kwargs.get('mode', 'a') not in ['r', 'r+', 'a']: | |||
| raise ValueError('mode %s is not allowed while performing a read. ' | |||
| 'Allowed modes are r, r+ and a.' % kwargs.get('mode')) | |||
|
@iamsimha minor changes. ping when green. |
iamsimha
force-pushed
the
fixing_issue_13623
branch
from
8359d0b to
b03d90b
Compare
|
@jreback I have made the changes. |
|
thanks @iamsimha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes ERR: disallow read_hdf mode='w' #13623
tests added / passed
passes
git diff upstream/master | flake8 --diffwhatsnew entry
Passing mode='w' to read_hdf raises ValueError.