Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: rename Timestamp.offset to .freq #13593

Closed
wants to merge 1 commit into from

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Jul 9, 2016

@sinhrks sinhrks added the Deprecate Functionality to remove in pandas label Jul 9, 2016
@sinhrks sinhrks added this to the 0.19.0 milestone Jul 9, 2016
# Temp,
# Categorical.categories is changed from str to bytes in PY3
# maybe the same as GH 13591
if PY3 and b.categories.inferred_type == 'string':
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be the same issue as #13591

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-io
Copy link

codecov-io commented Jul 9, 2016

Current coverage is 84.31%

No coverage report found for master at 1edc1df.

Powered by Codecov. Last updated by 1edc1df...c7749d5

@sinhrks sinhrks force-pushed the depr_timestamp_offset branch from ec2fe22 to c7749d5 Compare July 10, 2016 01:57
else:
tm.assert_categorical_equal(a, b)
elif a is NaT:
assert b is NaT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should prob change the comparators to be like the rest of pandas (e.g. assertTrue).... but can do later

@sinhrks sinhrks force-pushed the depr_timestamp_offset branch from c7749d5 to 5491fb6 Compare July 10, 2016 21:38
@jreback jreback closed this in 2a96ab7 Jul 10, 2016
@jreback
Copy link
Contributor

jreback commented Jul 10, 2016

thanks @sinhrks

I had to do a couple of more renames to avoid the warnings...but no biggie.

not that Timestamp.from_ordinal also needed changing, but I don't think its tested much.

@sinhrks sinhrks deleted the depr_timestamp_offset branch July 10, 2016 21:48
@sinhrks
Copy link
Member Author

sinhrks commented Jul 10, 2016

Thanks, let me do a follow-up for testing fromordinal.

jreback pushed a commit that referenced this pull request Jul 15, 2016
follow-up for #13593

Author: sinhrks <[email protected]>

Closes #13610 from sinhrks/depr_timestamp_offset2 and squashes the following commits:

28f8d41 [sinhrks] TST: add tests for Timestamp.toordinal
nateGeorge pushed a commit to nateGeorge/pandas that referenced this pull request Aug 15, 2016
closes pandas-dev#12160

Author: sinhrks <[email protected]>

Closes pandas-dev#13593 from sinhrks/depr_timestamp_offset and squashes the following commits:

c7749d5 [sinhrks] DEPR: rename Timestamp.offset to .freq
gfyoung added a commit to forking-repos/pandas that referenced this pull request Dec 24, 2017
jreback pushed a commit that referenced this pull request Dec 26, 2017
hexgnu pushed a commit to hexgnu/pandas that referenced this pull request Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPR: rename Timestamp.offset internally .freq / deprecate passing offset in favor of freq
3 participants