-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Make Styler ignore None index names to match to_html behaviour #12260
Conversation
Actual commit: 0cb2be1 |
Tests are failing on lint with files this PR doesn't touch: https://travis-ci.org/pydata/pandas/jobs/107799224#L1134-L1154
|
Joris is fixing that here. I'll restart your travis build once that's merged. |
@HHammond can you rebase on master when you get a chance. I think it should be a clean rebase. |
Closes pandas-dev#11692 Closes pandas-dev#12134 Closes pandas-dev#12125 This adds a `.format` method to Styler for formatting the display value (the actual text) of each scalar value. In the processes of cleaning up the template, I close pandas-dev#12134 (spurious 0) and pandas-dev#12125 (KeyError from using iloc improperly) cherry pick test from pandas-dev#12126 only allow str formatting for now fix tests for new spec formatter callable update notebook
0cb2be1
to
48c2f4c
Compare
@jreback Wanted to double check with you before I mess anything up, the merge script will handle this merge cleanly right? There's the two commits, one of which is now in master. Second commit has no conflicts. |
you can run the merge script then pause when it asked if u want to push upstream |
OK, thanks. I'll document that in the wiki. |
For some reason, the travis builds started to fail after merging this one. But does not seem to be related at first sight ("ImportError: libgfortran.so.1: cannot open shared object file: No such file or directory" and "ERROR: test_get_all_data (pandas.io.tests.test_data.TestYahooOptions)") |
Looking into it now, sorry. |
Also redoes some of the changes that were inadvertently revereted in pandas-dev#12260. That PR had two commits, one of which was an older version of what was eventually merged in pandas-dev#12162. The stale commit incorrectly merged was a15248a. It should have been a3c38fe. For the most part the changes were just style, but there was a python2 import error, which our tests didn't fail on because I was trying to catch a jinja ImportError, and instead caught all ImportErrors.
Also redoes some of the changes that were inadvertently revereted in #12260. That PR had two commits, one of which was an older version of what was eventually merged in #12162. The stale commit incorrectly merged was a15248a. It should have been a3c38fe. For the most part the changes were just style, but there was a python2 import error, which our tests didn't fail on because I was trying to catch a jinja ImportError, and instead caught all ImportErrors.
Addresses #12090 (comment) by making the
Styler
behaviour match regularto_html
behaviour.This PR is based from #12162.
New behaviour
cc @TomAugspurger