Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Bug in DataFrame.replace with a datetime64[ns, tz] and a non-compat to_replace #11326 #11329

Merged
merged 2 commits into from
Oct 17, 2015

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Oct 14, 2015

closes #11326
xref #11153

@jreback jreback added Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Dtype Conversions Unexpected or buggy dtype conversions labels Oct 14, 2015
@jreback jreback added this to the 0.17.1 milestone Oct 14, 2015
@jreback jreback force-pushed the replace branch 2 times, most recently from 792955b to 091120d Compare October 16, 2015 15:45
@jreback
Copy link
Contributor Author

jreback commented Oct 16, 2015

@sinhrks I ended up rewriting replace/fillna quite a bit to make much more generic. as lots of duplicated code in #11153

This simplifies quite a bit.

lmk if you have comments.

@jreback jreback force-pushed the replace branch 5 times, most recently from 79f1072 to c0ad658 Compare October 16, 2015 22:04
@sinhrks sinhrks mentioned this pull request Oct 16, 2015
jreback added a commit that referenced this pull request Oct 17, 2015
BUG: Bug in DataFrame.replace with a datetime64[ns, tz] and a non-compat to_replace #11326
@jreback jreback merged commit 03b131a into pandas-dev:master Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame with TimeSeries column raises TypeError in 0.17.0 when replacing ints or floats
2 participants