BUG: Fix to_dict() problem when using datetime DataFrame #11247 #11327
Conversation
|
see guidelines here: http://pandas.pydata.org/pandas-docs/stable/contributing.html dont' turn on PEP changes for your editor. |
|
I think I forgot to fetch to update my local master before my first commit to this PR. Somehow I messed up is it true? |
|
add tests! (ideally for each one of the orients if we dont' have already). |
jreback
added
Bug
Output-Formatting
|
which test case shall I add in? I am new to this :)
|
ethanluoyc
force-pushed
the
record-fix
branch
from
32ae03d to
3aec4db
Compare
|
@jreback I have added tests:) |
| def test_to_dict_timestamp(self): | ||
| # GH11247 | ||
| tsmp = Timestamp('20130101') | ||
| test_data = DataFrame({'A': [tsmp, tsmp], 'B': [tsmp, tsmp]}) |
There was a problem hiding this comment.
can you make this a mixed frame ,e.g. add a float and a string say. obviously need to adjust the tests as well.
There was a problem hiding this comment.
I adjusted the tests and now it tests both mixed and single dtypes
|
pls add a whatsnew note for 0.17.1 in bug fixes |
ethanluoyc
force-pushed
the
record-fix
branch
from
b6d654a to
d92c89a
Compare
|
Just asking what I should do if I merge updates locally with my branch and need to merge the 2 commits into one.. — On Fri, Oct 16, 2015 at 6:25 AM, Jeff Reback [email protected]
|
ethanluoyc
force-pushed
the
record-fix
branch
from
d92c89a to
971045e
Compare
Fix a bug where to_dict() does not return Timestamp when there is only datetime dtype present.
ethanluoyc
force-pushed
the
record-fix
branch
from
971045e to
938b076
Compare
|
merged via 89b4e5b thanks! |
closes #11247
This is my first time contributing through PR so forgive me if I make any silly mistake.
The issue can be referred to in GH11247
I followed @jreback 's suggestion to box things up in
to_dict()but I am not sure if this is what he means because I do not know exactly when_maybe_datetime()should be used. Initially I tried to tweakinternals.pybut it fails.Let me know how I can improve from here. Hope I can really learn from my first PR.