PERF: Checking monotonic-ness before sorting on an index #11080 #11294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3152,6 +3152,13 @@ def sort_index(self, axis=0, level=None, ascending=True, inplace=False, | |||
| else: | |||
| from pandas.core.groupby import _nargsort | |||
|
|
|||
| if (ascending and labels.is_monotonic_increasing) or \ | |||
There was a problem hiding this comment.
pls add a comment describing what you are doing here and a reference to the issue
|
pls add some benchmarks that I indicated in the issue (or point to ones that have this covered) |
jreback
added
Indexing
scari
force-pushed
the
master
branch
3 times, most recently
from
b63024e to
fcd592f
Compare
|
Added a
|
|
@scari I think you did something wrong with rebasing (as there are a lot of other commits here). Can yo do and then push again. |
|
@jorisvandenbossche Thanks for your kind guidance! I just push again. |
jreback
added a commit
that referenced
this pull request
Oct 14, 2015
PERF: Checking monotonic-ness before sorting on an index #11080
|
thanks @scari |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11080
Worked for this during PyCon JP 2015 pandas sprint /w @sinhrks
I found
test_frame.py:TestDataFrame.test_sort_indexcover this change.