DEPR: Series.nlargest/nsmallest take_last. #10920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Reshaping
1 task
| if f.__name__ in ['nsmallest', 'nlargest']: | ||
| if len(args) == 0: | ||
| decl = ['self', 'n=5', "keep='first'"] | ||
| args = ['self', 'n', 'keep'] |
There was a problem hiding this comment.
don't do this
simply define the function and treat normally (eg see irow)
sinhrks
force-pushed
the
nlargest
branch
2 times, most recently
from
2fb8bdc to
3a8d1d6
Compare
|
@jreback Yes, updated. |
jreback
added a commit
that referenced
this pull request
Aug 29, 2015
DEPR: Series.nlargest/nsmallest take_last.
|
thank you sir! |
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Mar 16, 2017
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Mar 16, 2017
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Mar 17, 2017
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Mar 17, 2017
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Mar 17, 2017
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Mar 17, 2017
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Mar 17, 2017
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Mar 17, 2017
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Mar 17, 2017
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-dev#10236, pandas-dev#10792, pandas-dev#10920. Author: gfyoung <[email protected]> Closes pandas-dev#15710 from gfyoung/create-last-kw-drop and squashes the following commits: b416290 [gfyoung] MAINT: Drop take_last kwarg from method signatures
mattip
pushed a commit
to mattip/pandas
that referenced
this pull request
Apr 3, 2017
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-dev#10236, pandas-dev#10792, pandas-dev#10920. Author: gfyoung <[email protected]> Closes pandas-dev#15710 from gfyoung/create-last-kw-drop and squashes the following commits: b416290 [gfyoung] MAINT: Drop take_last kwarg from method signatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10792.
Because using
deprecate_kwargshides original impl, used ugly workaround forGroupBy...