Tests for ABC Types #10859
Closed
Tests for ABC Types #10859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanNi0130 normally you don't need to open a new pull request, just update the existing one. see contribution docs here |
| sparse_array = pd.SparseArray(np.random.randn(10)) | ||
|
|
||
| def test_abc_indices(self): | ||
| self.assertIsInstance(pd.Index(['a', 'b', 'c']), com.ABCIndex) |
There was a problem hiding this comment.
add the issue number as a comment here
There was a problem hiding this comment.
just call this test_abc_types or something; indicies are very specific
|
small comment, pls squash. ping when green. |
|
You want me to add the issue number as a comment in the code? I just fixed the function name. |
|
yes |
|
Done! |
|
as i said. pls squash to a single commit. ping when travis reports green. |
Added tests for ABC Types, Issue pandas-dev#10828 change function name for test_abc_types Issue pandas-dev#10859
|
merged via 18012f0 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10828
I used self.assertIsInstance(obj, type) and inlined as many of the expressions as I could while staying PEP8 compliant. I added in the two tests that I took out, that was an accident. Let me know if this looks okay!