ENH: added rsplit to StringMethods #10303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [u('f'), u('g'), u('h')]]) | ||
| tm.assert_series_equal(result, exp) | ||
|
|
||
| def test_rsplit(self): |
There was a problem hiding this comment.
Can you add some cases using maxsplit and expand=True?
|
Thanks! I think this is OK for 0.16.2 as a follow-up of string enh if there is no objections. Could you update:
|
mortada
force-pushed
the
str_rsplit
branch
2 times, most recently
from
acdf6ac to
b267437
Compare
|
@sinhrks it's updated, please take a look |
| @@ -79,6 +79,8 @@ See the :ref:`documentation <basics.pipe>` for more. (:issue:`10129`) | |||
| .. _magrittr: https://github.com/smbache/magrittr | |||
| .. _R: http://www.r-project.org | |||
|
|
|||
| - Added `rsplit` to Index/Series StringMethods | |||
There was a problem hiding this comment.
add the PR number here as the issue number
jreback
added a commit
that referenced
this pull request
Jun 9, 2015
ENH: added rsplit to StringMethods
|
thanks! |
24 tasks
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a part of #9111
cc @sinhrks