Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations of levels in categorical in 2017/ after 0.18 #8376

Closed
jankatins opened this issue Sep 23, 2014 · 6 comments
Closed

Deprecations of levels in categorical in 2017/ after 0.18 #8376

jankatins opened this issue Sep 23, 2014 · 6 comments
Labels
Categorical Categorical Data Type Deprecate Functionality to remove in pandas
Milestone

Comments

@jankatins
Copy link
Contributor

levels was renamed to categories. Take out the deprecated property, the proerty in the Series.cat accessor, and the attribute in the constructor

Look for TODO: Remove after deprecation period in 2017/ after 0.18 and TODO: remove levels after the deprecation period.

Should be added to #6581

@jreback jreback added the Deprecate Functionality to remove in pandas label Sep 23, 2014
@jreback jreback added this to the 0.16 milestone Sep 23, 2014
@jreback jreback added the Categorical Categorical Data Type label Sep 23, 2014
@jtratner
Copy link
Contributor

@JanSchulz what's going to happen to functions like reorder_levels and remove_unused_levels? Are those going to be replaced as well? I was inspired by this to go change all the references to levels in Categorical docs to categories, and then noticed these other functions.

@jtratner
Copy link
Contributor

additionally, reorder_levels has a different meaning for Series and DataFrame

@jreback
Copy link
Contributor

jreback commented Sep 24, 2014

this is already fixed (just not merged yet): #8153

@jreback
Copy link
Contributor

jreback commented Sep 24, 2014

@jtratner reorder_levels is not the method anyhow, its s.cat.reorder_levels() (now s.cat.reorder_categories()) doesn't act on the Series OR DataFrame, rather on an embedded Categorical

@jankatins
Copy link
Contributor Author

The <whatever_levels> methods in Categorical and Series.cat.<whatever>_levels were never public API in a stable release, so don't need a deprecation cycle.

@jtratner
Copy link
Contributor

I was just behind the times here :)

On Wed, Sep 24, 2014 at 1:53 PM, Jan Schulz [email protected]
wrote:

The <whatever_levels> methods in Categorical and
Series.cat._levels were never public API, so don't need a
deprecation cycle.


Reply to this email directly or view it on GitHub
#8376 (comment).

@jreback jreback modified the milestones: 0.16, 0.15.1 Oct 7, 2014
@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 6, 2015
gfyoung added a commit to forking-repos/pandas that referenced this issue Jul 14, 2016
@jreback jreback added this to the 0.19.0 milestone Jul 15, 2016
@jreback jreback removed this from the Next Major Release milestone Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Deprecate Functionality to remove in pandas
Projects
None yet
Development

No branches or pull requests

3 participants