-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Series.groupby fails with InvalidIndexError on time series with a tuple-named grouper. #42731
Comments
There are simple solutions like to catch |
Thanks @suoniq for the report.
first bad commit: [2000334] Backport PR #36147: REGR: Series access with Index of tuples/frozenset (#36332) cc @rhshadrach similar issue #37755 |
This is to determine whether the grouper is of the form e.g.
This seems like the right approach to me - the method is attempting to access the grouper name from the frame, and on any failure return False. It even seems to me this would be an appropriate place to just catch |
@simonjayhawkins - I think this should be on the 1.3.2 milestone, is that right? |
Sure, count me in. Never contributed here before. So I have to dig into your tests first. But I'll go for it. |
I don't tend to put older regressions on the current backport milestone as it's more of a tracker than a project task list. If we get a PR to fix, can then assess whether we can/ want to backport. Regressions and bug fixes are allowable in a patch release. |
I have checked that this issue has not already been reported.
I have confirmed this bug exists on the latest version of pandas.
(optional) I have confirmed this bug exists on the master branch of pandas.
Code Sample, a copy-pastable example
Problem description
There are several things necessary to trigger this:
pd.Timestamp
s. If you change the example tos = pd.Series(index=[0,1], name=('A', 1))
everything is fine.groupby
'sby
argument , has to be aSeries
named with a tuple (like you get if you select aMultiIndex
-column from aDataFrame
). If you change the example tos.groupby((s==s).rename('foo'))
everything is fine. Same goes if you use a pure list or a function.Series
. If you change the example topd.DataFrame(s).groupby(s==s)
everything is fine.pandas>=1.1.3
. If you downgrade to an older version - guess what - everything is fine.Why this is a problem: The name of a grouper should not matter and it is just not to understand why a time series behaves differently than any other kind of
Series
.Expected Output
Behavior should be as for non-time-series.
Output of
pd.show_versions()
INSTALLED VERSIONS
commit : db08276
python : 3.8.3.final.0
python-bits : 64
OS : Windows
OS-release : 10
Version : 10.0.19041
machine : AMD64
processor : Intel64 Family 6 Model 158 Stepping 13, GenuineIntel
byteorder : little
LC_ALL : None
LANG : None
LOCALE : de_DE.cp1252
pandas : 1.1.3
numpy : 1.20.3
pytz : 2021.1
dateutil : 2.8.2
pip : 21.1.3
setuptools : 52.0.0.post20210125
Cython : None
pytest : 6.2.4
hypothesis : None
sphinx : None
blosc : None
feather : None
xlsxwriter : None
lxml.etree : None
html5lib : None
pymysql : None
psycopg2 : None
jinja2 : None
IPython : None
pandas_datareader: None
bs4 : None
bottleneck : 1.3.2
fsspec : None
fastparquet : None
gcsfs : None
matplotlib : None
numexpr : 2.7.3
odfpy : None
openpyxl : None
pandas_gbq : None
pyarrow : None
pytables : None
pyxlsb : None
s3fs : None
scipy : None
sqlalchemy : None
tables : None
tabulate : None
xarray : None
xlrd : None
xlwt : None
numba : None
The text was updated successfully, but these errors were encountered: