Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: numpydev is failing #30043

Closed
TomAugspurger opened this issue Dec 4, 2019 · 5 comments
Closed

CI: numpydev is failing #30043

TomAugspurger opened this issue Dec 4, 2019 · 5 comments
Labels
CI Continuous Integration

Comments

@TomAugspurger
Copy link
Contributor

==================================== ERRORS ====================================
_____ ERROR at setup of TestCasting.test_astype_object_series[data-object] _____
[gw1] linux -- Python 3.7.5 /home/vsts/miniconda3/envs/pandas-dev/bin/python

allow_in_pandas = None, dtype = PandasDtype('object')

    @pytest.fixture
    def data_missing(allow_in_pandas, dtype):
        # For NumPy <1.16, np.array([np.nan, (1,)]) raises
        # ValueError: setting an array element with a sequence.
        if dtype.numpy_dtype == "object":
            if _np_version_under1p16:
                raise pytest.skip("Skipping for NumPy <1.16")
>           return PandasArray(np.array([np.nan, (1,)]))
E           DeprecationWarning: Creating an ndarray with automatic object dtype is deprecated, use dtype=object if you intended it, otherwise specify an exact dtype

from https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=22360.

So numpy has deprecated object-dtype inference. I'm not sure if something like np.array([object(), object()]) warns now, or if it's just when the elements are sequences of difference lengths.

Anyway, this is a nice change, but will be a bit of work to get fixed.

@TomAugspurger TomAugspurger added the CI Continuous Integration label Dec 4, 2019
@jreback
Copy link
Contributor

jreback commented Dec 4, 2019

@jbrockmendel ideally could just xfail the test for now to get CI green (i saw your patch for some of these); i mean the rest

@TomAugspurger
Copy link
Contributor Author

In theory, we can just pass dtype=object everywhere. Will try that quick.

@TomAugspurger
Copy link
Contributor Author

Ahh, nevermind, this is going to be somewhat tricky to get right... I think we'll need to disable the numpydev build for now.

TomAugspurger added a commit to TomAugspurger/pandas that referenced this issue Dec 4, 2019
xref pandas-dev#30043.
Will take some time to fix all these cases.
jreback pushed a commit that referenced this issue Dec 4, 2019
* CI: disable numpydev job

xref #30043.
Will take some time to fix all these cases.

* mypy fixup
proost pushed a commit to proost/pandas that referenced this issue Dec 19, 2019
* CI: disable numpydev job

xref pandas-dev#30043.
Will take some time to fix all these cases.

* mypy fixup
proost pushed a commit to proost/pandas that referenced this issue Dec 19, 2019
* CI: disable numpydev job

xref pandas-dev#30043.
Will take some time to fix all these cases.

* mypy fixup
@jreback
Copy link
Contributor

jreback commented Dec 27, 2019

@jbrockmendel @TomAugspurger looks closeable yes?

@jbrockmendel
Copy link
Member

Yes, numpy has reverted the warning and in this particular case weve updated our usage to avoid the warning. closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

No branches or pull requests

3 participants