Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI allowed failure - TestReadHtml.test_thousands_macau_index_col[bs4] #28125

Closed
simonjayhawkins opened this issue Aug 24, 2019 · 6 comments
Closed
Labels
CI Continuous Integration Duplicate Report Duplicate issue or pull request IO HTML read_html, to_html, Styler.apply, Styler.applymap

Comments

@simonjayhawkins
Copy link
Member

=================================== FAILURES ===================================
_______________ TestReadHtml.test_thousands_macau_index_col[bs4] _______________
[gw1] linux -- Python 3.6.9 /home/travis/miniconda3/envs/pandas-dev/bin/python
self = <pandas.tests.io.test_html.TestReadHtml object at 0x7f11591bf5c0>
datapath = <function datapath.<locals>.deco at 0x7f1157bd3a60>
    @pytest.mark.slow
    def test_thousands_macau_index_col(self, datapath):
        all_non_nan_table_index = -2
        macau_data = datapath("io", "data", "macau.html")
>       dfs = self.read_html(macau_data, index_col=0, header=0)
pandas/tests/io/test_html.py:389: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
pandas/io/html.py:1095: in read_html
    displayed_only=displayed_only,
pandas/io/html.py:912: in _parse
    raise_with_traceback(retained)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
exc = AttributeError("'NoneType' object has no attribute 'items'",)
traceback = None
    def raise_with_traceback(exc, traceback=Ellipsis):
        """
        Raise exception with existing traceback.
        If traceback is not passed, uses sys.exc_info() to get traceback.
        """
        if traceback == Ellipsis:
            _, _, traceback = sys.exc_info()
>       raise exc.with_traceback(traceback)
E       AttributeError: 'NoneType' object has no attribute 'items'
pandas/compat/__init__.py:46: AttributeError

It appears that this started failing with #27962

cc @jbrockmendel

@simonjayhawkins simonjayhawkins added the CI Continuous Integration label Aug 24, 2019
@simonjayhawkins
Copy link
Member Author

probably not due to #27962, several changes in dependencies..

11c11
< beautifulsoup4            4.8.0                    py36_0
---
> beautifulsoup4            4.7.1                    py36_1
26c26
< cython                    0.29.13          py36he6710b0_0
---
> cython                    0.29.12          py36he6710b0_0
71c71
< lxml                      4.4.1            py36hefd8a0e_0
---
> lxml                      4.3.4            py36hefd8a0e_0
84c84
< numexpr                   2.7.0            py36h9e4a6bb_0
---
> numexpr                   2.6.9            py36h9e4a6bb_0
90c90
< pandas                    0.25.0+199.gbe08902a7           dev_0    <develop>
---
> pandas                    0.25.0+198.g325dd686d           dev_0    <develop>
93c93
< pip                       19.2.2                   py36_0
---
> pip                       19.1.1                   py36_0
114c114
< pyyaml                    5.1.2            py36h7b6447c_0
---
> pyyaml                    5.1.1            py36h7b6447c_0
121c121
< scipy                     1.3.1            py36h7c811a0_0
---
> scipy                     1.3.0            py36h7c811a0_0
127c127
< sqlalchemy                1.3.7            py36h7b6447c_0
---
> sqlalchemy                1.3.5            py36h7b6447c_0
135c135
< werkzeug                  0.15.5                     py_0
---
> werkzeug                  0.15.4                     py_0

@simonjayhawkins simonjayhawkins added the IO HTML read_html, to_html, Styler.apply, Styler.applymap label Aug 24, 2019
@TomAugspurger
Copy link
Contributor

@simonjayhawkins where is (or was?) this failing? It seems like the latest are all passing.

@simonjayhawkins
Copy link
Member Author

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Aug 26, 2019 via email

@simonjayhawkins
Copy link
Member Author

seeing this issue locally. can confirm that the bump in the version of beautifulsoup4 causes this test failure.

@simonjayhawkins
Copy link
Member Author

closing in favor of #29622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Duplicate Report Duplicate issue or pull request IO HTML read_html, to_html, Styler.apply, Styler.applymap
Projects
None yet
Development

No branches or pull requests

2 participants