Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture STDOUT For Validations Script Tests #22483

Closed
WillAyd opened this issue Aug 23, 2018 · 5 comments · Fixed by #22543
Closed

Capture STDOUT For Validations Script Tests #22483

WillAyd opened this issue Aug 23, 2018 · 5 comments · Fixed by #22543
Labels
good first issue Testing pandas testing functions or related to the test suite

Comments

@WillAyd
Copy link
Member

WillAyd commented Aug 23, 2018

See
#20061 (comment)

@WillAyd WillAyd added Testing pandas testing functions or related to the test suite good first issue labels Aug 23, 2018
@gfyoung
Copy link
Member

gfyoung commented Aug 24, 2018

The capture_stdout decorator in pandas/util/testing.py is a good place to start.

@rcromo
Copy link

rcromo commented Aug 29, 2018

Hello @WillAyd @gfyoung I am looking to make my first open source contribution.

Would you mind explaining a little more on the issue. What is the STDOUT supposed to be captured to ( a variable ?).

@gfyoung
Copy link
Member

gfyoung commented Aug 29, 2018

@rcromo : Thanks for wanting to contribute! Let me answer your question:

STDOUT is not a variable. It's the name of the location (or stream, rather) where anything you print goes. What we want to do is redirect the print statements to another location that doesn't cause them to be displayed in the terminal output on Travis.

@rcromo
Copy link

rcromo commented Aug 29, 2018

@gfyoung Thanks for the response. I know the STDOUT isn't a variable, I meant to ask where specifically does it have to be redirected to.

@gfyoung
Copy link
Member

gfyoung commented Aug 29, 2018

Ah, gotcha. Per my comment above, see how we implemented capture_stdout in pandas/util/testing.py. There is no specific place in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants