-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RLS: 0.23.0 #20531
Comments
Thanks for opening this. I'll go through the issues and mark ones that should be blockers, and push others. |
Doing that as well. I created the 0.24.0 milestone, in case you wan't to push an issue, but not into the big pile of "next major release" |
I would like to see 1 of the other existing types converted to EA before release. This will shake things down more. Likely the easiest is datetime w/tz. |
Mmm I started on Interval this morning. Won't be too much work to finish
that off. I can look into datetime w/ TZ as well.
…On Fri, Mar 30, 2018 at 2:17 PM, Jeff Reback ***@***.***> wrote:
I would like to see 1 of the other existing types converted to EA before
release. This will shake things down more. Likely the easiest is datetime
w/tz.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#20531 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIt6fz0fmeR_K9tq7cU2DdtgfjYbKks5tjoS8gaJpZM4TAMfv>
.
|
yeah the more the better, its going to surface other things. not necessarily will cause an api change, but that's the exercise (as it indeed might) |
During the dev meeting we discussed postponing further ExtensionArray things until 0.24. Is that still OK with everyone? This would make the EA changes currently in master 100% backwards compatible. Moving Period / Interval to ExtensionArray will "breaking" since they aren't coerced to ndarrays of objects. I'm still traveling this week, but will focus on reviewing PRs that are close, fixing blockers, and finalizing the EA docs (noting the experimental status). Then we can target a release candidate for Monday the 23, and plan to do the final release on April 27th or 30th? |
yeah I think that schedule sounds good. I moved most things off of the milestone. So let's see what's left. |
In general, can we add a comment if an issue is moved in case it is labeled with things like "regression" or "blocker". Then at least there is a notification for it, instead of it happening silently. Related, we can also make a temporary milestone 0.23.0rc to have a more focused one, without the need to remove regression/blockers (that we should still try to fix for 0.23.0) from the 0.23.0 milestone |
I think we'll be able to do a release candidate tomorrow (the 27th). |
it looks like statsmodels will be doing 0.9 soon |
Do we want to get a release out before PyCon? I'm available to do the release stuff on Monday the 7th, which means we should do an RC today, but we still have a decent number of issues and PRs open. Of the open PRs, I think the ones that may not be ready to merge immediately are
These are close I think
I'm going to push on the close ones over the next hour or two. I'd like to avoid major changes between the RC and final if possible. |
I guess in the next few hours we'll also decide about #20770 (the recently added docstring might need a review, but I guess it's better to squeeze that after the rc than the refactoring itself) |
Sorry for missing #20770. Added to the close list. |
i agree it would be nice to push a release before pycon, but I suspect we need a non-trivial RC period, this release is huge. Also we need to wait for statsmodels final I think as well (for #18341) and just to test. So I still lhave to fix for some comments on #20583 but if ok on the api, then ok to merge. |
No need to wait on statsmodels IMO, we can just merge that PR in the next release (I mean, it would be nice to get rid of it, but it's not that it is urgent or release critical for us)
I still disagree on the deprecation part, but let's discuss there |
stastmodels-0.9.0rc1 is out |
Down to
May push #20885 till after the RC Looking at #20844 now. Does anyone have objections to be doing the RC this afternoon? |
shouldn't you mention you are compatible with Pyside2 ? (now that Qt makes an official statment http://blog.qt.io/blog/2018/04/13/qt-for-python-is-coming-to-a-computer-near-you/ ) A little marketing for the new officially supported Qt interface #20905 |
Just need a go / no-go on #20347, then I'm tagging the RC. |
Yep, that one is not really critical for the RC (only a specific EA case), good enough for final release. |
OK, tagging the RC now. |
Thanks a lot, Tom! |
thanks Tom! fantastic as usual |
We didn't quite hit our deadline, but I think we're on track for a release this week sometime. |
@TomAugspurger decks clear. just a minor comment on your PR. otherwise lgtm. (I will review a couple of PR's later, but only will merge if ready). |
OK, thanks. I think we're all set for a release today. I'll start on the process in ~2 hours. |
yep just fixing pandas-wheels i think new version of futures broke this |
OK, tagging! |
Tagged, pushed, and created the release. FYI, @cgohlke not sure if you monitor our releases page, but the one at release at https://github.com/pandas-dev/pandas/releases/tag/v0.23.0 was initially messed up by me pressing enter, resulting in a https://github.com/pandas-dev/pandas/releases/tag/v0.23.0 is the correct tag / release |
Awesome work, thanks Tom! |
All done. Going to clean up the release automation stuff I started in https://github.com/pandas-dev/pandas-release. |
Also thanks a lot for all this infrastructure work! |
Follow-up for 0.23.0: we already branched for 0.23.x ? |
Yes, I created 0.23.x off the 0.23.0 release commit. I think we have some depredations / API breaking changes that are ready to go into master. |
OK, I just merged a first one with #18341 |
@pandas-dev/pandas-core reminder on the backporting workflow: Everything goes into master. We set the milestone to the correct version (e.g. 0.23.1) and we label items that need to be backported with the "Needs backport" label. When those are backported, we remove the label. |
And to add to that: it goes into master in such a way that it is easy to backport. So if we decide a PR is for 0.23.1, the whatsnew the PR adds should be in v0.23.1.txt and not v0.24.0.txt, which means we decide before merging which version it targets. |
Release Checklist
This template can be copied into the RLS issue for a release and checked off as you go.
Pre-Release
build_dist.sh
, uninstall cython and make a test install of the tarball to ensurecython is not required for installation from tarball/pypi (now also part of travis scripts, but check).
pandas.pydata.org
(@TomAugspurger or Andy Terrel should be able to get you an account).Release Candidate
These are items that must be done for an RC. See the respective sections for details.
RC Conda Packages
Conda-forge doesn't support release candidates yet. We build them ourselves.
The Release
Final Pre-Release
To be done just before tagging the commit. This is optional for release-candidates.
scripts/announce.py
and add torelease.rst
release.rst
andwhatsnew/<version>.rst
Tag the Release
git commit --allow-empty -m 'RLS: v0.20.0'
-m 'RLS: v0.20.0.rc2'
git tag -a v0.20.0
-m "Version 0.20.0"Test the Release
Some local sanity tests before pushing, making the release official
Push the Release
This is where things become final. No going back once the tagged commit is pushed
git push upstream master --follow-tags
git push upstream 0.20.x --follow-tags
Build Source Distribution
git clean -xdf pandas && python setup.py cython && python setup.py sdist --formats=gztar
(TODO: update build_dist.sh to handle maintenance branches)Release on Github
pandas-<version>.tar.gz
from the previous step as a "binary"openssl dgst -sha256 dist/pandas-<version>.tar.gz
We use the SHA from our .tar.gz since the one auto-generated by Github isn't stable if the release page
is later modified.
Build Binary Distributions
Windows wheels are built automatically by Christoph Gohlke.
BUILD_COMMIT
hereDownload Binary Distributions
Conda-Forge is handled automatically. We handle wheels.
python scripts/fetch_wheels.py
, from hereUpload to PyPI
Upload the source and wheels simultaneously. Uploading just the source may break some users'
workflows, if they trigger an update but don't have a C-complier
dist
:twine upload dist/*
Build and Upload the Docs
ln -sfn version/0.22.0 stable
ln -sfn 0.22.0 0.22
Update the Website
https://github.com/pandas-dev/pandas-website.git
latest.rst
toprevious.rst
latest.rst
releases.json
andpre_release.json
(if RC, add to pre_release.json, else make it blank)_themes/pydata/layout.html
to have the most recent minor release of each major versionmake html
make upload
(this requires an SSH key for the docs server)/Pandas_Cheet_Sheet.{pdf,pptx}
are up to date (TODO: automate)Announce
** Final Version**
** Release Candidates **
Start the next release cycle
Only after a major release
When finishing a major release we have a few extra steps to ensure that
the development version is always ahead of the backports version.
git checkout -b 0.20.x master
git push -u upstream 0.20.x
git checkout master
git commit --allow-empty -m 'DEV: Start 0.21 cycle'
git tag -a v0.21.0.dev0 -m 'Version 0.21.0 start'
git push upstream master --follow-tags
Finish
Miscellany I haven't gotten to yet.
Update documentation
git log v0.18.1.. --format='%an#%s' | grep -v Merge > commits
release.rst
):cat commits | gawk -F '#' '{ print "- " $1 }' | sort | uniq
release.rst
with highlights of whatsnew).Tracking issue for 0.23.0
(edited the milestone target date from end of March to end of April)
cc @pandas-dev/pandas-core
The text was updated successfully, but these errors were encountered: