Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Improve code quality of doc/make.py #19631

Closed
datapythonista opened this issue Feb 10, 2018 · 0 comments · Fixed by #19634
Closed

DOC: Improve code quality of doc/make.py #19631

datapythonista opened this issue Feb 10, 2018 · 0 comments · Fixed by #19634
Labels
Clean Docs
Milestone
0.23.0

Comments

@datapythonista
Copy link
Member

In #18949, python files in the scripts/ directory were reviewed to pass PEP-8, and added to lint. But doc/make.py was left out, as it wasn't in that directory.

Besides PEP-8 problems, make.py has repetitive code that could be avoided by a refactoring.

Also, #15591 and #10340 can be addressed as part of this refactoring.
@datapythonista datapythonista mentioned this issue Feb 10, 2018
Merged
4 tasks
@jreback jreback added this to the Next Major Release milestone Feb 10, 2018
@jreback jreback modified the milestones: Next Major Release, 0.23.0 Feb 22, 2018
jreback pushed a commit that referenced this issue Feb 22, 2018
@datapythonista @jreback
DOC: Improving code quality of doc/make.py, PEP-8, refactoring and re…
b27c541 
…moving unused commands (#19631) (#19634)
This was referenced Feb 22, 2018
Closed
Merged
harisbal pushed a commit to harisbal/pandas that referenced this issue Feb 28, 2018
@datapythonista
DOC: Improving code quality of doc/make.py, PEP-8, refactoring and re…
11c14e1 
…moving unused commands (pandas-dev#19631) (pandas-dev#19634)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Docs
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

DOC: Improving code quality of doc/make.py, PEP-8 and refactoring (#19631)
2 participants
@jreback @datapythonista