Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build no longer caching lib.pyx #19467

Closed
jbrockmendel opened this issue Jan 30, 2018 · 3 comments · Fixed by #19472
Closed

Build no longer caching lib.pyx #19467

jbrockmendel opened this issue Jan 30, 2018 · 3 comments · Fixed by #19472
Labels
Build Library building on various platforms
Milestone
0.23.0

Comments

@jbrockmendel
Copy link
Member

I think this is a fairly recent phenomenon. setup.py build_ext --inplace is now taking 40-60 seconds even if nothing has changed since the last run. It looks like lib.pyx is getting re-cythonized on each run.
@jreback
Copy link
Contributor

jreback commented Jan 30, 2018

yes this seems very recent

@jreback jreback added the Build Library building on various platforms label Jan 30, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 30, 2018
@jbrockmendel
Copy link
Member Author

Looks like it was introduced in #19306.

@jbrockmendel
Copy link
Member Author

setup.lib_depends still has 'reduce' in it. PR coming up to delete it, fixes this locally.

jbrockmendel added a commit to jbrockmendel/pandas that referenced this issue Jan 31, 2018
@jbrockmendel
setup.py fixup, closes pandas-dev#19467
cffb327
@jbrockmendel jbrockmendel mentioned this issue Jan 31, 2018
Merged
4 tasks
jreback pushed a commit that referenced this issue Jan 31, 2018
@jbrockmendel @jreback
setup.py fixup, closes #19467 (#19472)
65639e6
harisbal pushed a commit to harisbal/pandas that referenced this issue Feb 28, 2018
@jbrockmendel
setup.py fixup, closes pandas-dev#19467 (pandas-dev#19472)
e25a475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

Remove 'reduce' from lib_depends, closes #19467 jbrockmendel/pandas
2 participants
@jreback @jbrockmendel