-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: change .astype(.., raise_on_error) -> errors #14878
Comments
I can start to look at this one |
sure, should be pretty straightforaward |
I've noticed that the |
@m-charlton yes that would be fine (you can make an issue if you want to address later). if you want to put in the same PR that is ok too. (just indicate in the top-notes that 2 things are getting deprecated) |
Thinking about it, I'l raise it as a separate issue and make the changes to |
The above kw is being replaced by 'errors' - with legal values of ['raise', 'ignore'], with default value of 'raise'git
Valid arguments for new 'errors' kwarg are 'ignore' or 'raise' see pandas-dev#14878
xref #14877
this is inconsistent with our current API handling
so need to deprecate
raise_on_error
, AFAICT, this is the only public use, and adderrors='raise'|'ignore'
, with a default araise
.The text was updated successfully, but these errors were encountered: