Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: change .astype(.., raise_on_error) -> errors #14878

Closed
jreback opened this issue Dec 14, 2016 · 5 comments · Fixed by #14967
Closed

DEPR: change .astype(.., raise_on_error) -> errors #14878

jreback opened this issue Dec 14, 2016 · 5 comments · Fixed by #14967
Labels
Deprecate Functionality to remove in pandas Dtype Conversions Unexpected or buggy dtype conversions
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Dec 14, 2016

xref #14877

this is inconsistent with our current API handling

so need to deprecate raise_on_error, AFAICT, this is the only public use, and add
errors='raise'|'ignore', with a default a raise.

@jreback jreback added Deprecate Functionality to remove in pandas Difficulty Novice Dtype Conversions Unexpected or buggy dtype conversions labels Dec 14, 2016
@jreback jreback added this to the Next Major Release milestone Dec 14, 2016
@m-charlton
Copy link
Contributor

I can start to look at this one

@jreback
Copy link
Contributor Author

jreback commented Dec 14, 2016

sure, should be pretty straightforaward

@m-charlton
Copy link
Contributor

I've noticed that the DataFrame.where method (pandas/core/internals.py) also
has a raise_on_error keyword argument. Should this be raised as a separate
issue? I can get on with the changes to astype.

@jreback
Copy link
Contributor Author

jreback commented Dec 19, 2016

@m-charlton yes that would be fine (you can make an issue if you want to address later). if you want to put in the same PR that is ok too. (just indicate in the top-notes that 2 things are getting deprecated)

@m-charlton
Copy link
Contributor

Thinking about it, I'l raise it as a separate issue and make the changes to astype first. That
way, if I miss out anything on the deprecation of raise_on_error on astype I should not make the the same mistake on the second deprecation in the where method. When raising the new issue, I'll
link back to this one.

m-charlton added a commit to m-charlton/pandas that referenced this issue Dec 21, 2016
The above kw is being replaced by 'errors' - with legal values of
['raise', 'ignore'], with default value of 'raise'git
m-charlton added a commit to m-charlton/pandas that referenced this issue Dec 22, 2016
Valid arguments for new 'errors' kwarg are 'ignore' or 'raise'
see pandas-dev#14878
@jreback jreback modified the milestones: 0.20.0, Next Major Release Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants