Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Cleanup plotting submodule #12548

Closed
sinhrks opened this issue Mar 6, 2016 · 2 comments · Fixed by #16005
Closed

CLN: Cleanup plotting submodule #12548

sinhrks opened this issue Mar 6, 2016 · 2 comments · Fixed by #16005
Labels
Clean Visualization plotting
Milestone
0.20.0

Comments

@sinhrks
Copy link
Member

sinhrks commented Mar 6, 2016 •
edited
Loading

  • Make plotting as subpackage
    • Split utility functions / non- MPLPlot classes to other files.
  • Move tests under plotting/*
    • Add small unit tests to guarantee utility function APIs.
  • Refactor MPLPlot class properties. Because MPLPlot now has lots of properties, split them to FigureProperties and AxesProperties classes and delegates the logic.

This should makes #12547, #7670, #8018 easier.
@sinhrks sinhrks added this to the 0.18.1 milestone Mar 6, 2016
@sinhrks
Copy link
Member Author

sinhrks commented Mar 9, 2016

Hopefully the cleanup should fix issues like #12565.

@TomAugspurger
Copy link
Contributor

I've been wanting to do a cleanup for a while too :)

I won't really have time to take the lead on this, but I can at least commit to reviewing and testing everything.

@jreback jreback modified the milestones: Next Major Release, 0.18.1 Apr 25, 2016
@sinhrks sinhrks mentioned this issue Jul 7, 2016
Closed
4 tasks
@jorisvandenbossche jorisvandenbossche mentioned this issue Apr 14, 2017
Merged
jreback pushed a commit that referenced this issue Apr 15, 2017
@jorisvandenbossche @jreback
CLN/API: move plotting funcs to pandas.plotting (#16005)
7993fc8 
closes #12548
@jreback jreback modified the milestones: 0.20.0, Next Major Release Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Visualization plotting
Projects
None yet
Milestone
0.20.0
3 participants
@jreback @TomAugspurger @sinhrks