make things less obvious

pandas-dev · Feb 21, 2018 · ba2d4ca · ba2d4ca · jreback · Feb 21, 2018
1 parent 88c9638
commit ba2d4ca
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pandas/tests/indexes/test_base.py b/pandas/tests/indexes/test_base.py
@@ -7,6 +7,7 @@
 from collections import defaultdict
 
 import pandas.util.testing as tm
+from pandas.core.dtypes.generic import ABCIndex
 from pandas.core.dtypes.common import is_unsigned_integer_dtype
 from pandas.core.indexes.api import Index, MultiIndex
 from pandas.tests.indexes.common import Base
@@ -2319,8 +2320,9 @@ def test_ensure_index_from_sequences(self, data, names, expected):
                                     'pow', 'rpow', 'mod', 'divmod'])
 def test_generated_op_names(opname, indices):
     index = indices
-    if type(index) is pd.Index and opname == 'rsub':
-        # method doesn't exist, see GH#19723
+    if isinstance(index, ABCIndex) and opname == 'rsub':
+        # pd.Index.__rsub__ does not exist; though the method does exist
+        # for subclasses.  see GH#19723
         return
     opname = '__{name}__'.format(name=opname)
     method = getattr(index, opname)