Skip to content

Commit

Permalink
Just use euo pipefail instead of l
Browse files Browse the repository at this point in the history
  • Loading branch information
mroeschke committed Aug 16, 2023
1 parent 7b168da commit 3552e77
Show file tree
Hide file tree
Showing 8 changed files with 20 additions and 24 deletions.
6 changes: 3 additions & 3 deletions .github/actions/build_pandas/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ runs:
micromamba info
micromamba list
pip list --pre
shell: bash -el {0}
shell: bash -euo pipefail {0}

- name: Uninstall existing Pandas installation
run: |
if pip show pandas 1>/dev/null; then
pip uninstall -y pandas
fi
shell: bash -el {0}
shell: bash -euo pipefail {0}

- name: Build Pandas
run: |
Expand All @@ -29,4 +29,4 @@ runs:
else
pip install . --no-build-isolation -v
fi
shell: bash -el {0}
shell: bash -euo pipefail {0}
4 changes: 2 additions & 2 deletions .github/actions/run-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ runs:
steps:
- name: Test
run: ci/run_tests.sh
shell: bash -el {0}
shell: bash -euo pipefail {0}

- name: Publish test results
uses: actions/upload-artifact@v3
Expand All @@ -15,7 +15,7 @@ runs:

- name: Report Coverage
run: coverage report -m
shell: bash -el {0}
shell: bash -euo pipefail {0}
if: failure()

- name: Upload coverage to Codecov
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/code-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
runs-on: ubuntu-22.04
defaults:
run:
shell: bash -el {0}
shell: bash -euo pipefail {0}

concurrency:
# https://github.community/t/concurrecy-not-work-for-push/183068/7
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
runs-on: ubuntu-22.04
defaults:
run:
shell: bash -el {0}
shell: bash -euo pipefail {0}

concurrency:
# https://github.community/t/concurrecy-not-work-for-push/183068/7
Expand Down Expand Up @@ -131,7 +131,7 @@ jobs:
runs-on: ubuntu-22.04
defaults:
run:
shell: bash -el {0}
shell: bash -euo pipefail {0}

concurrency:
# https://github.community/t/concurrecy-not-work-for-push/183068/7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/comment-commands.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
if: github.event.issue.pull_request && startsWith(github.event.comment.body, '@github-actions benchmark')
defaults:
run:
shell: bash -el {0}
shell: bash -euo pipefail {0}
env:
ENV_FILE: environment.yml
COMMENT: ${{github.event.comment.body}}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docbuild-and-upload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:

defaults:
run:
shell: bash -el {0}
shell: bash -euo pipefail {0}

steps:
- name: Checkout
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/package-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ permissions:

defaults:
run:
shell: bash -el {0}
shell: bash -euo pipefail {0}

jobs:
pip:
Expand Down Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Pip install with extra
run: |
python -m pip install .[${{ matrix.extra }}] -v
shell: bash -el {0}
shell: bash -euo pipefail {0}
conda_forge_recipe:
if: ${{ github.event.label.name == 'Build' || contains(github.event.pull_request.labels.*.name, 'Build') || github.event_name == 'push'}}
runs-on: ubuntu-22.04
Expand Down
10 changes: 3 additions & 7 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ permissions:

defaults:
run:
shell: bash -el {0}
shell: bash -euo pipefail {0}

jobs:
ubuntu:
Expand Down Expand Up @@ -337,10 +337,8 @@ jobs:
with:
python-version: '3.12-dev'

- name: Build Environment
- name: Install Environment
run: |
${{ steps.pydev.outputs.python-path }} -m venv ~/virtualenvs/pandas-dev
. ~/virtualenvs/pandas-dev/bin/activate
python --version
python -m pip install --upgrade pip setuptools wheel meson[ninja]==1.0.1 meson-python==0.13.1
python -m pip install --pre --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy
Expand All @@ -350,6 +348,4 @@ jobs:
python -m pip list
- name: Run Tests
run: |
. ~/virtualenvs/pandas-dev/bin/activate
ci/run_tests.sh
uses: ./.github/actions/run-tests
10 changes: 5 additions & 5 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
- name: Output sdist name
id: save-path
shell: bash -el {0}
shell: bash -euo pipefail {0}
run: echo "sdist_name=$(ls ./dist)" >> "$GITHUB_OUTPUT"

build_wheels:
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:

- name: Output sdist name (macOS)
id: save-path
shell: bash -el {0}
shell: bash -euo pipefail {0}
run: echo "sdist_name=$(ls ./dist)" >> "$GITHUB_ENV"

# Python version used to build sdist doesn't matter
Expand All @@ -135,7 +135,7 @@ jobs:
- name: Output sdist name (macOS)
id: save-path2
shell: bash -el {0}
shell: bash -euo pipefail {0}
run: echo "sdist_name=$(cd ./dist && ls -d */)" >> "$GITHUB_ENV"

- name: Build wheels
Expand All @@ -158,7 +158,7 @@ jobs:
cache-environment: true

- name: Validate wheel RECORD
shell: bash -el {0}
shell: bash -euo pipefail {0}
run: for whl in $(ls wheelhouse); do wheel unpack wheelhouse/$whl -d /tmp; done

# Testing on windowsservercore instead of GHA runner to fail on missing DLLs
Expand All @@ -181,7 +181,7 @@ jobs:

- name: Upload wheels & sdist
if: ${{ success() && (env.IS_SCHEDULE_DISPATCH == 'true' || env.IS_PUSH == 'true') }}
shell: bash -el {0}
shell: bash -euo pipefail {0}
env:
PANDAS_STAGING_UPLOAD_TOKEN: ${{ secrets.PANDAS_STAGING_UPLOAD_TOKEN }}
PANDAS_NIGHTLY_UPLOAD_TOKEN: ${{ secrets.PANDAS_NIGHTLY_UPLOAD_TOKEN }}
Expand Down

0 comments on commit 3552e77

Please sign in to comment.