Skip to content

Commit

Permalink
Revert changes to pass numeric_only
Browse files Browse the repository at this point in the history
  • Loading branch information
kprestel committed Nov 11, 2018
1 parent 61dcee3 commit 0a785d5
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions pandas/core/groupby/groupby.py
Original file line number Diff line number Diff line change
Expand Up @@ -1755,8 +1755,7 @@ def cummin(self, axis=0, **kwargs):
if axis != 0:
return self.apply(lambda x: np.minimum.accumulate(x, axis))

return self._cython_transform('cummin',
numeric_only=kwargs.get('numeric_only') or False)
return self._cython_transform('cummin', numeric_only=False)

@Substitution(name='groupby')
@Appender(_doc_template)
Expand All @@ -1765,8 +1764,7 @@ def cummax(self, axis=0, **kwargs):
if axis != 0:
return self.apply(lambda x: np.maximum.accumulate(x, axis))

return self._cython_transform('cummax',
numeric_only=kwargs.get('numeric_only') or False)
return self._cython_transform('cummax', numeric_only=False)

def _get_cythonized_result(self, how, grouper, aggregate=False,
cython_dtype=None, needs_values=False,
Expand Down

0 comments on commit 0a785d5

Please sign in to comment.